vmm: clean up migration threads on failure - #188
Merged
olivereanderson merged 1 commit intoJul 29, 2026
Merged
Conversation
Migration threads may be left orphaned and keep the socket bound after a migration has failed. Prevent this by signaling termination via the `terminate_fd` in `ReceiveAdditionalConnections`'s `Drop` impl. On-behalf-of: SAP julian.schindel@sap.com Signed-off-by: Julian Schindel <julian.schindel@cyberus-technology.de>
amphi
approved these changes
Jul 29, 2026
olivereanderson
merged commit Jul 29, 2026
d00bdc0
into
cyberus-technology:gardenlinux
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration threads may be left orphaned and keep the socket bound after a migration has failed. Prevent this by signaling termination via the
terminate_fdinReceiveAdditionalConnections'sDropimpl.As far as I can tell, we cannot test this in libvirt because it doesn't expose a way to create the conditions that the migration fails.
Backport of cloud-hypervisor#8656
Fixes https://github.com/cobaltcore-dev/cobaltcore/issues/640