You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A method for obtaining the time storage format has been added to the driver class. To avoid breaking backward compatibility, a separate interface has been allocated for this method.
🤔 Why?
In some cases, it is necessary to know in what format time is stored.
For example, see Issue 66 of cycle/migrations
After investigating, we fixed the issue entirely on the cycle/migrations side in cycle/migrations#67, without needing a new driver API: the migrator now passes created_at to the WHERE clause as a DateTimeInterface object instead of a pre-formatted string, so the driver formats it exactly the same way as on insert — consistently with the withDatetimeMicroseconds option. The migration table's datetime columns are also created with datetime(6) now, which fixes the related failure on SQL Server (legacy DATETIME rejects values with microseconds).
Since getDateTimeFormat() is no longer required for that fix, I'm closing this PR. If a use case comes up where exposing the driver's datetime format is genuinely needed, we can revisit the idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
A method for obtaining the time storage format has been added to the driver class. To avoid breaking backward compatibility, a separate interface has been allocated for this method.
🤔 Why?
In some cases, it is necessary to know in what format time is stored.
For example, see Issue 66 of cycle/migrations
📝 Checklist