Develop #2224
Merged
Develop #2224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* provide proper `--args` for any place utilizing rawRender- `changelog.js`- `note.js` now renders with rawRender * rawRender returns promise and not string `Note.js` update to reflect that rawRender returns a promise and not a string * pre-process `--` => keyword, then post-process keyword => `--` This feels like a hack, but it resolves the issue.
* Update cy.writeFile() yields description The yielded value is either a string, or a javascript object that was stringified to the file, in short - contents parameter. The examples already reflect contents parameter is yielded. * Change 'parameter' to 'argument' to match noun used in doc minor grammar Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
On platforms without a decent grep, it seems stop-only does a poor job of correctly detecting focused tests. There's an eslint plugin which is much more suitable, use that instead. While changing eslint config, tidy up the lint commands and fix a couple of minor issues in files that were not being linted. Exclude public/ and themes/ folders from lint, cover everything else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.