-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Cypress-SignalR-Mock plugin #5378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for benevolent-cat-040f48 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
Could you please explain how your CI automatically tests? It looks like the tests are in the workflow https://github.com/JasonLandbridge/Cypress-SignalR-Mock/blob/master/.github/workflows/test.yml which is triggered by You may need to add an event trigger |
|
@MikeMcC399, that was only to fix the workflow files, which i got recently working. Normally any changes will happen through a PR, as can be seen here: JasonLandbridge/Cypress-SignalR-Mock#5 I will change the repo setting that direct pushes are not possible anymore |
I also noticed in your workflow (https://github.com/JasonLandbridge/Cypress-SignalR-Mock/blob/master/.github/workflows/test.yml) that some steps are repeated and could be optimized. (This is not anything to stop accepting your plugin. I just wanted to mention it for your benefit.)
cypress-io/github-action has documentation and examples in the repo to assist. name: Run Unit and Cypress Tests
on:
pull_request:
branches: [ master ]
paths-ignore:
- '.github/**'
- '.idea/**'
- '.run/**'
- '.vscode/**'
jobs:
Testing:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [ 16.x ]
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- name: NPM Clean Install
run: npm ci
- name: Execute Unit tests
run: npm run test
- name: Execute Typechecking
run: npm run type-check
- name: Cypress run
uses: cypress-io/github-action@v5
with:
build: npm ci && npm run build
start: npm run cypress:ci
working-directory: ./playground
|
|
@MikeMcC399 , Thank you very much for that extensive feedback! I will make sure to correct it! |
This is attempt 2: #5231
I have ensured the Cypress runs as part of the CI with a Cypress test that displays the plugin working
Plugin link: Cypress-SignalR-Mock
Before submitting your plugin, please check to see if it fulfills these requirements:
If you have reason to believe your plugin does not need to meet certain requirements, please feel free to provide justification below: