Skip to content

Forward mount_data_store from analysis submission into job model - #301

Merged
ianmcorvidae merged 5 commits into
cyverse-de:mainfrom
ianmcorvidae:vice-optional-data-store-mount
Jul 22, 2026
Merged

Forward mount_data_store from analysis submission into job model#301
ianmcorvidae merged 5 commits into
cyverse-de:mainfrom
ianmcorvidae:vice-optional-data-store-mount

Conversation

@ianmcorvidae

Copy link
Copy Markdown
Member

The field existed in the AnalysisSubmission schema and in model.Job, but build-submission silently dropped it. Add it to the outgoing job map with a default of true so that omitting the field from a submission preserves the existing behaviour.

The field existed in the AnalysisSubmission schema and in model.Job, but
build-submission silently dropped it. Add it to the outgoing job map with
a default of true so that omitting the field from a submission preserves
the existing behaviour.

@psarando psarando left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@psarando psarando left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM 👍

@ianmcorvidae

Copy link
Copy Markdown
Member Author

I'm going to go ahead and merge this and get it deployed, along with the terrain update to common-swagger-api. Neither should do anything until the sonora or app-exposer PRs are merged since it's basically just plumbing.

@ianmcorvidae
ianmcorvidae merged commit fd082f5 into cyverse-de:main Jul 22, 2026
2 checks passed
@ianmcorvidae
ianmcorvidae deleted the vice-optional-data-store-mount branch July 22, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants