feat(094): smoke tests for remaining 9 shadcn UI primitives - #540
Merged
Conversation
Add smoke tests for the last untested shadcn UI components: - breadcrumb (8 tests): nav aria-label, list, items, link, page (aria-current), separator (role presentation), ellipsis, custom className - hover-card (5 tests): trigger, content (defaultOpen), data-slot, base classes, align/sideOffset props - toggle-group (7 tests): multiple/selection, variant, size, disabled, data-slots - aspect-ratio (6 tests): rendering, children, ratio props, custom className - avatar (6 tests): root, fallback initials, image src/alt, custom className - collapsible (6 tests): trigger click, defaultOpen, content, disabled, custom className - progress (8 tests): role progressbar, base classes, indicator, 0-100% values - slider (6 tests): ResizeObserver mock for jsdom, rendering, custom className - popover (5 tests): trigger, content (defaultOpen via Portal), align/sideOffset Code review fixes: ResizeObserver changed from vi.fn() to class mock (Radix requires constructor form), Adjustments for jsdom limitations (Radix image loading, aria-valuenow, roles) Validation: typecheck pass, lint pass, 18 files / 139 ui tests pass
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Up to standards ✅🟢 Issues
|
…d strict test for home page The upgraded assertion (serious+) surfaced 58+ pre-existing color-contrast issues across 7 views. Revert existing views to critical-only, keep strict for home page only. Track fixes in Plan 095.
- Add e2e/helpers/a11y.ts (shared axe-core helper from feat/093) - Update GOAL.md: accessibility audit E2E suite completed - Check off Plan 071 G5.5 with note about pre-existing contrast issues - Create Plan 095 for color-contrast fix follow-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan 094 — Smoke Tests for Remaining UI Primitives
Summary
Adds smoke tests for the last 9 untested shadcn UI components, following the same patterns established in Plans 092 and 093.
Changes
breadcrumb.test.tsxhover-card.test.tsxtoggle-group.test.tsxaspect-ratio.test.tsxavatar.test.tsxcollapsible.test.tsxprogress.test.tsxslider.test.tsxpopover.test.tsxCode Review Fixes Applied
vi.fn(() => ({...}))toclass ResizeObserverMock { ... }— Radix UI requires constructor form fornew ResizeObserver()aria-valuenowassertion — Radix doesn't set it in jsdom (covered by E2E axe checks)querySelectorAllinstead ofgetByRole— Radix items may not expose ARIA roles in jsdomcontainervariable (lint warning)Validation
Related