fix d2js CJS asset paths - #2793
Merged
Merged
Conversation
alixander
force-pushed
the
agent/fix-cjs-asset-path
branch
from
August 3, 2026 01:27
dc0057c to
d899863
Compare
alixander
force-pushed
the
agent/fix-cjs-asset-path
branch
from
August 3, 2026 01:30
d899863 to
a0a6e19
Compare
alixander
marked this pull request as ready for review
August 3, 2026 01:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Bun 1.3.14 inlined
import.meta.urlin the CommonJS bundle as the source path. The CJS integration test then looked forwasm_exec.jsoutsided2js/js, blocking the stage-only npm workflow before it could test trusted publishing. A packed-package review also found that Node treated the generated CJS.jsfiles as ESM because the root package usestype: module; the nested marker makes the declared require export work in Node.Verification
git diff --check@terrastruct/d2tarball installed in an isolated directory; both CommonJS and ESM builds compiledx -> yunder Node 24dist/node-cjs/package.jsonwith the CommonJS markerNothing is published or staged by this PR.