avoid pathological wasm optimization - #2796
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-O2instead of-Ozfor the large Go WASM packageWhy
The stage-only run spent more than 26 minutes inside
wasm-opt -Ozwithout reaching npm. An exact local reproduction remained CPU-active with about 2.36 GiB RSS and rising after 4m54s, with no output file. This matches WebAssembly/binaryen#7644:-O3/-Os/-Ozcan have quadratic memory growth on large Go WASM modules, and the maintainer recommends-O2. D2 currently includes the same goldmark code implicated by that issue.No staged npm artifact was created before the run was cancelled.
Validation
sh -n d2js/js/ci/build.shgit diff --check-O2 --enable-bulk-memory-optbenchmark completed in 14.83s with ~1.11 GiB peak RSS