compiler: index reversed equivalent edges - #2839
Merged
Merged
Conversation
alixander
force-pushed
the
agent/fix-reversed-edge-index
branch
2 times, most recently
from
August 10, 2026 01:38
695cc2e to
ca8e683
Compare
Signed-off-by: Alexander Wang <alex@terrastruct.com>
alixander
force-pushed
the
agent/fix-reversed-edge-index
branch
from
August 10, 2026 01:41
ca8e683 to
24a58dc
Compare
alixander
marked this pull request as ready for review
August 10, 2026 01:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treats a connection and its reversed notation as one index sequence when endpoint arrowheads describe the same semantics. For example,
a -- b/b -- a,a <-> b/b <-> a, anda -> b/b <- anow receive indexes 0 and 1; the genuinely oppositeb -> aremains a separate sequence.The change applies consistently across IR lookup/indexing, compiled graph lookup, and oracle reconnect ID deltas. It also replaces the original TODO in
d2graph.Edge.initIndex.Validation: