Skip to content

fix(deno): let the Deno stack produce a .deb - #80

Merged
Snider merged 1 commit into
mainfrom
fix/deno-deb-passthrough
Jul 28, 2026
Merged

fix(deno): let the Deno stack produce a .deb#80
Snider merged 1 commit into
mainfrom
fix/deno-deb-passthrough

Conversation

@Snider

@Snider Snider commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

deb, deb-maintainer and deb-description reach the root action and the orchestrator, and the Go stack declares them and hands them to package. The Deno stack never declared them, so the chain dead-ended there.

A Deno caller could set deb: true, watch the build go green, and get no .deb. dAppCore/ts asked for one:

package: true
deb: true
deb-maintainer: "Lethean <dev@lethean.io>"
deb-description: "CoreTS — client-side application server"

…and the Linux job produced only the zip. No dpkg-deb anywhere in the log.

Why #79's check missed it

That check looks for an input both a caller and its callee declare, where the caller forgets to forward. Not declaring an input is precisely how a stack says it does not offer that option — so "never declared" and "deliberately withheld" look identical to it. It was never going to catch this one.

It now also records, per callee input, which callers wire it and which don't:

$ python3 tests/action_contracts.py --asymmetries

  actions/package/action.yml :: deb
      wired by  actions/build/deno/action.yml, actions/build/go/action.yml
      not by    actions/build/bun/action.yml, actions/build/cpp/action.yml,
                actions/build/node/action.yml, actions/build/wails2/action.yml,
                actions/build/wails3/action.yml

Opt-in, and never fails. Most of the 33 it lists are correct — wails3 genuinely doesn't take wails2's options — so surfacing them every run would only teach people to skip the output, the same reasoning already applied to the lint job. It's the tool for wiring a new stack, or for working out why an option appears to do nothing.

The remaining deb gaps (bun, cpp, node, wails2, wails3) are a feature question, not a wiring bug, and are left alone.

Verification

$ python3 tests/action_contracts.py
checked 35 action.yml files — all sound
(33 caller asymmetries — run with --asymmetries to list them)

🤖 Generated with Claude Code
Co-Authored-By: Virgil virgil@lethean.io

`deb`, `deb-maintainer` and `deb-description` reach the root action and
the orchestrator, and the Go stack declares them and hands them to
package. The Deno stack never declared them, so the chain dead-ended
there: a Deno caller could set `deb: true`, watch the build go green and
get no .deb. dAppCore/ts asked for one and never got one.

The contract check added alongside the passthrough fixes could not catch
this. It looks for an input both a caller and its callee declare, and
not declaring an input is precisely how a stack says it does not offer
that option — so an input that was never declared reads the same as one
deliberately withheld.

So the check now also records, for each callee input, which callers wire
it and which do not, behind `--asymmetries`. Most of what it lists is
correct (wails3 does not take wails2's options), which is why it is
opt-in and never fails: on every run it would only teach people to skip
the output. It is the tool for wiring a new stack, or for working out
why an option appears to do nothing.

Co-Authored-By: Virgil <virgil@lethean.io>
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Snider, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5ddb2bff-f475-44f4-adb7-2ad5b0a748b3

📥 Commits

Reviewing files that changed from the base of the PR and between e6adcd0 and 5d0e1f9.

📒 Files selected for processing (3)
  • actions/action.yml
  • actions/build/deno/action.yml
  • tests/action_contracts.py

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Snider
Snider merged commit 1dd0af2 into main Jul 28, 2026
71 checks passed
@Snider
Snider deleted the fix/deno-deb-passthrough branch July 28, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant