Conversation
…#1220)
Land COMPLIANT-verdict use-core/go-correctly pass on cli. Audit went
from 100 findings → 0 (fully compliant per
/Users/snider/Code/core/go/tests/cli/v090-upgrade/audit.sh).
Highlights:
- pkg/cli/i18n.go: T() now routes through *Core.I18n().Translate(...)
when the CLI is initialised with a Core, falling back to the standalone
cli/pkg/i18n.Default().T() only when uninitialised. Adds three
i18n-key-builder helpers (wordLabel / progressMessage / actionFailed)
that compose key prefixes and call the canonical T(...)
- pkg/cli/commands.go: register-style refactor with Result propagation
- pkg/cli/{app,command,errors,output,runtime,utils,frame/layout}.go:
banned-import cleanup + core.E migration
- cmd/core/{config,doctor,help,pkgcmd}/...: Result propagation +
banned-import cleanup across 12 cmd files
21 files changed, 291/-180. Build, vet, test all clean.
audit.sh verdict: COMPLIANT (every counter at 0).
Closes tasks.lthn.sh/view.php?id=1220
Co-authored-by: Codex <noreply@openai.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings v0.10.0 to main: refactor(go) using core/go primitives correctly. First repo to hit audit-COMPLIANT verdict (100 → 0 findings). Closes Mantis #1220.