build(deps): go/process v0.16.3 — the Program.Find arm the last bump missed - #32
Merged
Conversation
…d arm) v0.16.2 fixed lookPath in process/exec and left a byte-identical copy in os_exec_link.go untouched. Program.Find calls that second one, which is why this lane measured `Program.Find: "git": not found in PATH` at 41 occurrences BEFORE v0.16.2 and 41 after — the bump that was supposed to clear the agent/* cluster could never have touched it. v0.16.3 collapses both copies into one shared internal/lookpath, so the three Windows defects — no %PATHEXT% expansion, a mode&0111 test the platform never satisfies, a path-vs-name check that missed '/' — now apply on the arm this repo actually calls. It also records a resolution failure on Cmd.Err rather than discarding it, so an unresolved name reports PATH instead of a working directory. Expected to move: agent/orchestrator, agent/provider, engine/driver (the three classified as App.Find/Program.Find). Posting the measured number rather than this expectation — the last two dependency bumps this lane took both cleared zero against confident predictions. Receipts — macOS: GOWORK=off go test -count=1 ./... exit=0, 176 packages ok GOWORK=off go build ./... · go vet ./... clean ./agent/... + ./engine/driver/: all ok (orchestrator 147.688s, workspace 90.519s, driver 6.713s) Co-Authored-By: Virgil <virgil@lethean.io>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates the direct ChangesProcess dependency update
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.16.2fixedlookPathinprocess/execand left a byte-identical copy inos_exec_link.gountouched.Program.Findcalls that second one — which is why this lane measuredProgram.Find: "git": not found in PATHat 41 occurrences before v0.16.2 and 41 after. The bump that was supposed to clear theagent/*cluster could never have touched it.v0.16.3(go-process#10) collapses both copies into one sharedinternal/lookpath, so the three Windows defects — no%PATHEXT%expansion, amode&0111test the platform never satisfies, a path-vs-name check that missed/— now apply on the arm this repo actually calls. It also records a resolution failure onCmd.Errrather than discarding it, so an unresolved name reports PATH instead of a working directory.Expected to move
agent/orchestrator,agent/provider,engine/driver— the three classified as theProgram.Findarm.I'm posting the measured number rather than this expectation. The last two dependency bumps this lane took (
go/process v0.16.2,core/go v0.12.1) both cleared zero against confident predictions, in both cases because the fix landed on a layer this repo doesn't call. That's twice; the expectation above is a hypothesis until the run says otherwise.Receipts — macOS
./agent/...+./engine/driver/— the packages this targets:Summary by CodeRabbit