test(webkit/window): finish the tautology sweep PR #46 left blocked - #50
Conversation
The four shells #46 could not touch while PR #44 was in flight, now adjudicated per case rather than swept. register_test.go — genuine fake. All three tests asserted that the string "Register:good" contains "good" and never named Register at all. Replaced with a real Good/Bad/Ugly triplet that calls it: the returned constructor yields an OK Result carrying a *Service wired to the given platform with manager and spec registry initialised (Good); a nil platform still constructs rather than panicking during Core wiring, long before any window opens (Bad); and the constructor is reusable, each call producing an INDEPENDENT service — a shared specs map would let two Cores overwrite each other's window registrations (Ugly). window_test.go — mislabelled but real. These tests DO call WithName / WithTitle / WithURL and assert properly; the ax7Variant lines were dead weight prepended to working bodies. Removed those two lines per test, 116 in total, leaving every assertion byte-identical. Receipts: coverage 68.3% before, 68.3% after — nothing real was removed Register 100.0% (was already covered by service_screen_test.go's real use; the deleted shells contributed nothing) go test -race -count=2 clean vet + gofmt clean Co-Authored-By: Virgil <virgil@lethean.io>
|
Warning Review limit reached
Next review available in: 17 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
The four shells #46 couldn't touch while #44 was in flight. Adjudicated per case rather than swept — the two files needed opposite treatments.
register_test.go— genuine fakeAll three tests asserted that the string
"Register:good"contains"good". They never namedRegister.Replaced with a real Good/Bad/Ugly triplet that actually calls it:
Resultcarrying a*Servicewired to the given platform, with manager and spec registry initialised.specsmap would let two Cores overwrite each other's window registrations.window_test.go— mislabelled but realThese tests do call
WithName/WithTitle/WithURLand assert properly. Theax7Variantlines were dead weight prepended to working bodies. Removed those two lines per test — 116 in total — leaving every assertion byte-identical.Receipts
Registerservice_screen_test.go's real use; the deleted shells contributed nothing)go test -race -count=2🤖 Generated with Claude Code
Co-Authored-By: Virgil virgil@lethean.io