Improve KuboCAS session cleanup

[0xSwego]

Summary

• keep TCP connections open for reuse and remove force_close
• add best-effort automatic cleanup via __del__
• verify session cleanup behaviour in unit tests

Testing

• bash run-checks.sh

---

https://chatgpt.com/codex/tasks/task_e_6849b9c8ca848324a86358c9da4b6a84

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Commit Unit Tests in branch codex/investigate-download-speed-regression-after-recent-changes
• Post Copyable Unit Tests in Comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 99.18%. Comparing base (342e545) to head (8f47ce7).
Report is 4 commits behind head on codex/investigate-unclosed-client-session-issue.

Files with missing lines	Patch %	Lines
py_hamt/store.py	77.27%	5 Missing ⚠️

Additional details and impacted files

@@                                 Coverage Diff                                 @@
##           codex/investigate-unclosed-client-session-issue      #70      +/-   ##
===================================================================================
- Coverage                                           100.00%   99.18%   -0.82%     
===================================================================================
  Files                                                    5        5              
  Lines                                                  597      616      +19     
===================================================================================
+ Hits                                                   597      611      +14     
- Misses                                                   0        5       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Faolain]

Some things

• Should this be pointed at main instead @0xSwego ?
• Also test coverage needs to be at 100% 🙏
• Version also would be 3.0.2

Lastly I ran the random-test repo we have against it and get this pending task destroyed (for reference we saw this before with one of my updates prior and I believe it is related to the lazy loading, not sure what this pending task is and if it would lead to issues with premature closing)

seemingly related? aio-libs/aiohttp#7551 probably should be fine for now? as long as we get full test coverage again can bump it to 3.0.2.

We don't see this issue when running pytest --ipfs because I think it's something to do with the loop that pytest provides (whereas in the async.run(...) it ends it abruptly where maybe the test harness is more graceful. I didn't take a deeper look but could be something to look into)

[Faolain]

Closing since it seems we will be going the httpx route in #71