This repository was archived by the owner on Jun 15, 2021. It is now read-only.
Conversation
* add daostack test / imports * add babel * add merkle payment pool
* remove DAOStack integration tests * zos -> oz update * test update
* add deploy script * update scripts
* update openzep dependencies * convert tests to use web3 contracts * test refactor add splitOnPay variant tests * update gitignore * add solcover settings * Add setup settings for coverage network
* separate deploy parameters * change oz manager
* add RewardsDistributor * wrapper, first unit tests * fix tests * more tests * better tests * bring back sender address for distribute events * comments * (spelling) reminder -> remainder
sethfork
self-requested a review
September 4, 2019 20:48
sethfork
suggested changes
Sep 4, 2019
sethfork
left a comment
sethfork
left a comment
Contributor
There was a problem hiding this comment.
Let's move the scalable dividends implementation to a feature branch and merge stale changes from dev.
Collaborator
Author
|
The scalable_dividends branch is already merged to dev. Agreed on feature branches going forward - how do you think we should do feature branches? I usually just do |
Collaborator
Author
|
Down to merge dev to master here, pending 1 review approval. |
dOrgJelli
approved these changes
Sep 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.