first string field takes preference as document link - #559
Merged
Conversation
added 2 commits
October 25, 2018 17:44
Co-Authored-By: abovedave <david@longworth.to>
Co-Authored-By: abovedave <david@longworth.to>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a small issue if you set a
Referencefield orMediafield as the first displayed field in your API schema you are unable to click through from the list view (both those fields override the link).It finds the first field of type
Stringand appends the document link to that value, even if it's not in position0. If there are noStringfields in the schema, it fallsback to position0