-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DS][7/n] Create MaterializedSchedulingCondition #21505
Merged
OwenKephart
merged 1 commit into
master
from
04-29-Create_MaterializedSchedulingCondition
May 3, 2024
Merged
[DS][7/n] Create MaterializedSchedulingCondition #21505
OwenKephart
merged 1 commit into
master
from
04-29-Create_MaterializedSchedulingCondition
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 29, 2024
ea93cfa
to
f5273ce
Compare
This was referenced Apr 30, 2024
7ba9e41
to
2b4edaf
Compare
f5273ce
to
af95b27
Compare
This was referenced Apr 30, 2024
2b4edaf
to
29984df
Compare
af95b27
to
19f0acf
Compare
29984df
to
76e39e7
Compare
19f0acf
to
a9f1908
Compare
d3366dc
to
4e8de78
Compare
schrockn
approved these changes
May 3, 2024
This was referenced May 3, 2024
02c3476
to
33521fa
Compare
4e8de78
to
cb86cfc
Compare
Merge activity
|
33521fa
to
f4adb47
Compare
cb86cfc
to
4dfad42
Compare
cmpadden
pushed a commit
that referenced
this pull request
May 6, 2024
## Summary & Motivation Creates a simple `MaterializedSchedulingCondition` and a base class `StatusSchedulingCondition`. The `StatusSchedulingCondition` class is there to make future implementations of things like "InProgressSchedulingCondition` simpler ## How I Tested These Changes
This was referenced May 6, 2024
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
## Summary & Motivation Creates a simple `MaterializedSchedulingCondition` and a base class `StatusSchedulingCondition`. The `StatusSchedulingCondition` class is there to make future implementations of things like "InProgressSchedulingCondition` simpler ## How I Tested These Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Creates a simple
MaterializedSchedulingCondition
and a base classStatusSchedulingCondition
.The
StatusSchedulingCondition
class is there to make future implementations of things like "InProgressSchedulingCondition` simplerHow I Tested These Changes