Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DS][7/n] Create MaterializedSchedulingCondition #21505

Merged
merged 1 commit into from
May 3, 2024

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

Creates a simple MaterializedSchedulingCondition and a base class StatusSchedulingCondition.

The StatusSchedulingCondition class is there to make future implementations of things like "InProgressSchedulingCondition` simpler

How I Tested These Changes

@OwenKephart OwenKephart force-pushed the 04-29-Create_MaterializedSchedulingCondition branch from ea93cfa to f5273ce Compare April 30, 2024 00:12
@OwenKephart OwenKephart force-pushed the 04-29-Create_Any/AllDepCondition branch from 7ba9e41 to 2b4edaf Compare April 30, 2024 15:52
@OwenKephart OwenKephart force-pushed the 04-29-Create_MaterializedSchedulingCondition branch from f5273ce to af95b27 Compare April 30, 2024 15:52
@OwenKephart OwenKephart force-pushed the 04-29-Create_Any/AllDepCondition branch from 2b4edaf to 29984df Compare April 30, 2024 23:32
@OwenKephart OwenKephart force-pushed the 04-29-Create_MaterializedSchedulingCondition branch from af95b27 to 19f0acf Compare April 30, 2024 23:32
@OwenKephart OwenKephart force-pushed the 04-29-Create_Any/AllDepCondition branch from 29984df to 76e39e7 Compare May 1, 2024 16:33
@OwenKephart OwenKephart force-pushed the 04-29-Create_MaterializedSchedulingCondition branch from 19f0acf to a9f1908 Compare May 1, 2024 16:33
Copy link
Contributor Author

OwenKephart commented May 3, 2024

Merge activity

  • May 3, 5:31 PM EDT: @OwenKephart started a stack merge that includes this pull request via Graphite.
  • May 3, 5:44 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 3, 5:45 PM EDT: @OwenKephart merged this pull request with Graphite.

@OwenKephart OwenKephart force-pushed the 04-29-Create_Any/AllDepCondition branch from 33521fa to f4adb47 Compare May 3, 2024 21:41
Base automatically changed from 04-29-Create_Any/AllDepCondition to master May 3, 2024 21:43
@OwenKephart OwenKephart force-pushed the 04-29-Create_MaterializedSchedulingCondition branch from cb86cfc to 4dfad42 Compare May 3, 2024 21:44
@OwenKephart OwenKephart merged commit df726e7 into master May 3, 2024
1 check was pending
@OwenKephart OwenKephart deleted the 04-29-Create_MaterializedSchedulingCondition branch May 3, 2024 21:45
cmpadden pushed a commit that referenced this pull request May 6, 2024
## Summary & Motivation

Creates a simple `MaterializedSchedulingCondition` and a base class `StatusSchedulingCondition`.

The `StatusSchedulingCondition` class is there to make future implementations of things like "InProgressSchedulingCondition` simpler

## How I Tested These Changes
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
## Summary & Motivation

Creates a simple `MaterializedSchedulingCondition` and a base class `StatusSchedulingCondition`.

The `StatusSchedulingCondition` class is there to make future implementations of things like "InProgressSchedulingCondition` simpler

## How I Tested These Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants