Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DS][14/n] Remove unused methods and properties #21535

Merged
merged 1 commit into from
May 3, 2024

Conversation

OwenKephart
Copy link
Contributor

@OwenKephart OwenKephart commented Apr 30, 2024

Summary & Motivation

As title.

How I Tested These Changes

Copy link
Contributor Author

OwenKephart commented Apr 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite Graphite

@OwenKephart OwenKephart changed the title [DS][x/n] Rename AssetConditionEvaluationContext to LegacyRuleEvaluationContext [DS][14/n] Rename AssetConditionEvaluationContext to LegacyRuleEvaluationContext Apr 30, 2024
@OwenKephart OwenKephart changed the title [DS][14/n] Rename AssetConditionEvaluationContext to LegacyRuleEvaluationContext [DS][14/n] Remove unused methods and properties Apr 30, 2024
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from b130055 to 4c6fcb3 Compare April 30, 2024 23:32
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from 4c6fcb3 to 4377a0a Compare May 1, 2024 16:34
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from 4377a0a to 9315240 Compare May 1, 2024 22:56
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from 9315240 to 7907df9 Compare May 1, 2024 23:02
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from 7907df9 to 497e409 Compare May 2, 2024 19:53
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from 497e409 to 8cc12c3 Compare May 2, 2024 22:17
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from 8cc12c3 to 67f0c6b Compare May 2, 2024 22:58
Copy link
Contributor Author

OwenKephart commented May 3, 2024

Merge activity

  • May 3, 5:31 PM EDT: @OwenKephart started a stack merge that includes this pull request via Graphite.
  • May 3, 5:59 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 3, 6:00 PM EDT: @OwenKephart merged this pull request with Graphite.

@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from 05df5d1 to abcee61 Compare May 3, 2024 21:57
Base automatically changed from 04-30-Convert_SchedulingContext_to_DagsterModel to master May 3, 2024 21:58
@OwenKephart OwenKephart merged commit 06d9ab8 into master May 3, 2024
1 check failed
@OwenKephart OwenKephart deleted the 04-30-Remove_unused_fields branch May 3, 2024 22:00
cmpadden pushed a commit that referenced this pull request May 6, 2024
## Summary & Motivation

As title.

## How I Tested These Changes
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
## Summary & Motivation

As title.

## How I Tested These Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants