Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DS][20/n] Port static constructors from AssetCondition to SchedulingCondition #21541

Merged

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

As title

How I Tested These Changes

Copy link
Contributor Author

OwenKephart commented Apr 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite Graphite

@OwenKephart OwenKephart changed the title [DS][x/n] Port static constructors to SchedulingCondition [DS][20/n] Port static constructors from AssetCondition to SchedulingCondition Apr 30, 2024
@OwenKephart OwenKephart force-pushed the 04-30-Create_SchedulingCondition_object_to_replace_AssetCondition branch from 776411b to e4a9098 Compare April 30, 2024 23:33
@OwenKephart OwenKephart force-pushed the 04-30-Port_static_constructors_to_SchedulingCondition branch from ec495ed to 70ee16a Compare April 30, 2024 23:33
@OwenKephart OwenKephart force-pushed the 04-30-Create_SchedulingCondition_object_to_replace_AssetCondition branch from e4a9098 to 85dacdb Compare May 1, 2024 16:34
@OwenKephart OwenKephart force-pushed the 04-30-Port_static_constructors_to_SchedulingCondition branch from 70ee16a to 7f2828a Compare May 1, 2024 16:34
@OwenKephart OwenKephart force-pushed the 04-30-Create_SchedulingCondition_object_to_replace_AssetCondition branch from 85dacdb to 5fe2c2d Compare May 1, 2024 22:56
@OwenKephart OwenKephart force-pushed the 04-30-Port_static_constructors_to_SchedulingCondition branch from 7f2828a to b2b16c8 Compare May 1, 2024 22:56
@OwenKephart OwenKephart force-pushed the 04-30-Create_SchedulingCondition_object_to_replace_AssetCondition branch from 5fe2c2d to 0902a81 Compare May 1, 2024 23:02
@OwenKephart OwenKephart force-pushed the 04-30-Port_static_constructors_to_SchedulingCondition branch from b2b16c8 to 37bc2ac Compare May 1, 2024 23:02
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this would be your opportunity to introduce a new static factory class.

@OwenKephart OwenKephart force-pushed the 04-30-Create_SchedulingCondition_object_to_replace_AssetCondition branch from 0902a81 to 9505365 Compare May 2, 2024 19:53
@OwenKephart OwenKephart force-pushed the 04-30-Port_static_constructors_to_SchedulingCondition branch from 37bc2ac to ab08e7e Compare May 2, 2024 19:53
@OwenKephart OwenKephart force-pushed the 04-30-Create_SchedulingCondition_object_to_replace_AssetCondition branch from 9505365 to 2a6363d Compare May 2, 2024 22:17
@OwenKephart OwenKephart force-pushed the 04-30-Port_static_constructors_to_SchedulingCondition branch from ab08e7e to 01b9122 Compare May 2, 2024 22:17
@OwenKephart OwenKephart force-pushed the 04-30-Create_SchedulingCondition_object_to_replace_AssetCondition branch from 2a6363d to 087d087 Compare May 2, 2024 22:59
@OwenKephart OwenKephart force-pushed the 04-30-Port_static_constructors_to_SchedulingCondition branch from 01b9122 to 7319552 Compare May 2, 2024 22:59
@OwenKephart OwenKephart force-pushed the 04-30-Create_SchedulingCondition_object_to_replace_AssetCondition branch from 99e8c49 to 122d0d4 Compare May 3, 2024 16:58
@OwenKephart OwenKephart force-pushed the 04-30-Port_static_constructors_to_SchedulingCondition branch from 79c58ad to 6264070 Compare May 3, 2024 16:58
@OwenKephart OwenKephart force-pushed the 04-30-Create_SchedulingCondition_object_to_replace_AssetCondition branch from 122d0d4 to b962b89 Compare May 3, 2024 21:11
@OwenKephart OwenKephart force-pushed the 04-30-Port_static_constructors_to_SchedulingCondition branch from 6264070 to de38ef2 Compare May 3, 2024 21:11
Copy link
Contributor Author

OwenKephart commented May 3, 2024

Merge activity

  • May 3, 5:31 PM EDT: @OwenKephart started a stack merge that includes this pull request via Graphite.
  • May 3, 6:14 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 3, 6:15 PM EDT: @OwenKephart merged this pull request with Graphite.

@OwenKephart OwenKephart force-pushed the 04-30-Create_SchedulingCondition_object_to_replace_AssetCondition branch from b962b89 to 8d0118f Compare May 3, 2024 22:11
Base automatically changed from 04-30-Create_SchedulingCondition_object_to_replace_AssetCondition to master May 3, 2024 22:12
@OwenKephart OwenKephart force-pushed the 04-30-Port_static_constructors_to_SchedulingCondition branch from de38ef2 to 81d443f Compare May 3, 2024 22:13
@OwenKephart OwenKephart merged commit 308efa5 into master May 3, 2024
1 check failed
@OwenKephart OwenKephart deleted the 04-30-Port_static_constructors_to_SchedulingCondition branch May 3, 2024 22:15
cmpadden pushed a commit that referenced this pull request May 6, 2024
…Condition (#21541)

## Summary & Motivation

As title

## How I Tested These Changes
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
…Condition (dagster-io#21541)

## Summary & Motivation

As title

## How I Tested These Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants