-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DS][20/n] Port static constructors from AssetCondition to SchedulingCondition #21541
Merged
OwenKephart
merged 1 commit into
master
from
04-30-Port_static_constructors_to_SchedulingCondition
May 3, 2024
Merged
[DS][20/n] Port static constructors from AssetCondition to SchedulingCondition #21541
OwenKephart
merged 1 commit into
master
from
04-30-Port_static_constructors_to_SchedulingCondition
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2024
This was referenced Apr 30, 2024
776411b
to
e4a9098
Compare
ec495ed
to
70ee16a
Compare
e4a9098
to
85dacdb
Compare
70ee16a
to
7f2828a
Compare
85dacdb
to
5fe2c2d
Compare
7f2828a
to
b2b16c8
Compare
5fe2c2d
to
0902a81
Compare
b2b16c8
to
37bc2ac
Compare
schrockn
requested changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this would be your opportunity to introduce a new static factory class.
0902a81
to
9505365
Compare
37bc2ac
to
ab08e7e
Compare
schrockn
approved these changes
May 2, 2024
9505365
to
2a6363d
Compare
ab08e7e
to
01b9122
Compare
2a6363d
to
087d087
Compare
01b9122
to
7319552
Compare
99e8c49
to
122d0d4
Compare
79c58ad
to
6264070
Compare
This was referenced May 3, 2024
122d0d4
to
b962b89
Compare
6264070
to
de38ef2
Compare
Merge activity
|
b962b89
to
8d0118f
Compare
Base automatically changed from
04-30-Create_SchedulingCondition_object_to_replace_AssetCondition
to
master
May 3, 2024 22:12
de38ef2
to
81d443f
Compare
cmpadden
pushed a commit
that referenced
this pull request
May 6, 2024
…Condition (#21541) ## Summary & Motivation As title ## How I Tested These Changes
This was referenced May 6, 2024
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
…Condition (dagster-io#21541) ## Summary & Motivation As title ## How I Tested These Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As title
How I Tested These Changes