Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DS][33/n] Create static constructor for cron condition #21703

Merged
merged 1 commit into from
May 14, 2024

Conversation

OwenKephart
Copy link
Contributor

@OwenKephart OwenKephart commented May 7, 2024

Summary & Motivation

Creates a sort of "distributed schedule" condition. In the limit (all nodes share the same schedule), this functions essentially equivalently to a regular @schedule, but this has the advantage of being possible to set on a per-node basis.

How I Tested These Changes

Copy link
Contributor Author

OwenKephart commented May 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite Graphite

Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops meant to req changes.

Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok cool. Please add at least one test case to ensure the object successful constructs before merge.

@OwenKephart OwenKephart force-pushed the 05-06-Update_UpdatedSinceCronCondition branch from 987910d to 11c36b7 Compare May 9, 2024 22:48
@OwenKephart OwenKephart force-pushed the 05-07-Create_cron_composite_condition branch from 9d4acc2 to a0b7aa1 Compare May 9, 2024 22:48
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

@OwenKephart OwenKephart force-pushed the 05-06-Update_UpdatedSinceCronCondition branch from 11c36b7 to 6930e6e Compare May 10, 2024 22:44
@OwenKephart OwenKephart force-pushed the 05-07-Create_cron_composite_condition branch from a0b7aa1 to 7670537 Compare May 10, 2024 22:44
@OwenKephart OwenKephart force-pushed the 05-06-Update_UpdatedSinceCronCondition branch from 6930e6e to 094fc47 Compare May 13, 2024 17:30
@OwenKephart OwenKephart force-pushed the 05-07-Create_cron_composite_condition branch from 7670537 to fb99336 Compare May 13, 2024 17:30
@OwenKephart OwenKephart force-pushed the 05-06-Update_UpdatedSinceCronCondition branch from 094fc47 to fd13670 Compare May 13, 2024 17:51
@OwenKephart OwenKephart force-pushed the 05-07-Create_cron_composite_condition branch from fb99336 to 83d6d9e Compare May 13, 2024 17:51
@OwenKephart OwenKephart force-pushed the 05-06-Update_UpdatedSinceCronCondition branch from fd13670 to d0ff38c Compare May 14, 2024 13:47
@OwenKephart OwenKephart force-pushed the 05-07-Create_cron_composite_condition branch from 83d6d9e to 88e7c85 Compare May 14, 2024 13:47
@OwenKephart OwenKephart force-pushed the 05-06-Update_UpdatedSinceCronCondition branch from d0ff38c to c050b50 Compare May 14, 2024 13:55
@OwenKephart OwenKephart force-pushed the 05-07-Create_cron_composite_condition branch from 88e7c85 to c28ae01 Compare May 14, 2024 13:55
@OwenKephart OwenKephart force-pushed the 05-06-Update_UpdatedSinceCronCondition branch from c050b50 to f098c04 Compare May 14, 2024 13:59
@OwenKephart OwenKephart force-pushed the 05-07-Create_cron_composite_condition branch 2 times, most recently from d51d353 to 6b6127f Compare May 14, 2024 14:14
Copy link
Contributor Author

OwenKephart commented May 14, 2024

Merge activity

  • May 14, 10:38 AM EDT: @OwenKephart started a stack merge that includes this pull request via Graphite.
  • May 14, 10:57 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 14, 10:58 AM EDT: @OwenKephart merged this pull request with Graphite.

@OwenKephart OwenKephart force-pushed the 05-06-Update_UpdatedSinceCronCondition branch from f098c04 to e795689 Compare May 14, 2024 14:55
Base automatically changed from 05-06-Update_UpdatedSinceCronCondition to master May 14, 2024 14:56
@OwenKephart OwenKephart force-pushed the 05-07-Create_cron_composite_condition branch from 6b6127f to 498ff6c Compare May 14, 2024 14:56
@OwenKephart OwenKephart merged commit 4b17e5d into master May 14, 2024
1 check was pending
@OwenKephart OwenKephart deleted the 05-07-Create_cron_composite_condition branch May 14, 2024 14:58
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
…1703)

## Summary & Motivation

Creates a sort of "distributed schedule" condition. In the limit (all nodes share the same schedule), this functions essentially equivalently to a regular `@schedule`, but this has the advantage of being possible to set on a per-node basis.


## How I Tested These Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants