-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DS][33/n] Create static constructor for cron condition #21703
Conversation
53b782d
to
5dc7a65
Compare
c8422a6
to
78e7ad7
Compare
5dc7a65
to
987910d
Compare
78e7ad7
to
9d4acc2
Compare
python_modules/dagster/dagster/_core/definitions/declarative_scheduling/scheduling_condition.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops meant to req changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok cool. Please add at least one test case to ensure the object successful constructs before merge.
987910d
to
11c36b7
Compare
9d4acc2
to
a0b7aa1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent
11c36b7
to
6930e6e
Compare
a0b7aa1
to
7670537
Compare
6930e6e
to
094fc47
Compare
7670537
to
fb99336
Compare
094fc47
to
fd13670
Compare
fb99336
to
83d6d9e
Compare
fd13670
to
d0ff38c
Compare
83d6d9e
to
88e7c85
Compare
d0ff38c
to
c050b50
Compare
88e7c85
to
c28ae01
Compare
c050b50
to
f098c04
Compare
d51d353
to
6b6127f
Compare
Merge activity
|
f098c04
to
e795689
Compare
6b6127f
to
498ff6c
Compare
…1703) ## Summary & Motivation Creates a sort of "distributed schedule" condition. In the limit (all nodes share the same schedule), this functions essentially equivalently to a regular `@schedule`, but this has the advantage of being possible to set on a per-node basis. ## How I Tested These Changes
Summary & Motivation
Creates a sort of "distributed schedule" condition. In the limit (all nodes share the same schedule), this functions essentially equivalently to a regular
@schedule
, but this has the advantage of being possible to set on a per-node basis.How I Tested These Changes