-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DS][28/n] Create WillBeRequestedCondition #21640
Conversation
c1120be
to
102f170
Compare
745c94c
to
ff7943c
Compare
102f170
to
a226325
Compare
ff7943c
to
5b377a0
Compare
Could you add a condition that instead of only working on any or all assets, it applies to an explicit subset? |
5b377a0
to
449ff84
Compare
e138ccc
to
f8b4f5d
Compare
449ff84
to
006a6b4
Compare
7c8a70c
to
a4f2744
Compare
ae6fe51
to
d01bb66
Compare
@@ -48,6 +48,31 @@ def compute_slice(self, context: SchedulingContext) -> AssetSlice: | |||
return context.asset_graph_view.compute_in_progress_asset_slice(context.asset_key) | |||
|
|||
|
|||
@whitelist_for_serdes | |||
class WillBeRequestedCondition(SliceSchedulingCondition): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think class name should include the word "tick" just like the static constructor and description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just req'ing changes based on class name to make sure you see it since the name will get serialized and it is hard to change.
d01bb66
to
389c08d
Compare
Adding that functionality to |
a4f2744
to
ba19f8d
Compare
389c08d
to
6a8d1b0
Compare
ba19f8d
to
1bd133f
Compare
6a8d1b0
to
7732a0a
Compare
1bd133f
to
56c11e4
Compare
7732a0a
to
09e1d91
Compare
Merge activity
|
56c11e4
to
10b0a4b
Compare
09e1d91
to
1a917ab
Compare
## Summary & Motivation Creates a WillBeRequestedCondition. Naming is somewhat sketch, but the basic idea is that in the past we've merged together this concept with existing rules. I.e. in AMP-world, the "skip_on_parent_missing" rule is actually "skip on parent (missing and will not be requested this tick)". This is obviously a bit confusing, and now that all of our dep conditions are composable, breaking this out into its own separate condition is desirable. ## How I Tested These Changes
Summary & Motivation
Creates a WillBeRequestedCondition. Naming is somewhat sketch, but the basic idea is that in the past we've merged together this concept with existing rules.
I.e. in AMP-world, the "skip_on_parent_missing" rule is actually "skip on parent (missing and will not be requested this tick)".
This is obviously a bit confusing, and now that all of our dep conditions are composable, breaking this out into its own separate condition is desirable.
How I Tested These Changes