[DS][19/n] Create SchedulingCondition object to replace AssetCondition #21540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2024
OwenKephart
changed the title
This was referenced Apr 30, 2024
OwenKephart
force-pushed
the
04-30-Move_serialized_objects_to_separate_file
branch
from
04bc8d9
to
46d8114
Compare
OwenKephart
force-pushed
the
04-30-Create_SchedulingCondition_object_to_replace_AssetCondition
branch
from
776411b
to
e4a9098
Compare
OwenKephart
force-pushed
the
04-30-Move_serialized_objects_to_separate_file
branch
from
46d8114
to
3fd2d0f
Compare
OwenKephart
force-pushed
the
04-30-Create_SchedulingCondition_object_to_replace_AssetCondition
branch
from
e4a9098
to
85dacdb
Compare
OwenKephart
force-pushed
the
04-30-Move_serialized_objects_to_separate_file
branch
from
3fd2d0f
to
b80f8c8
Compare
OwenKephart
force-pushed
the
04-30-Create_SchedulingCondition_object_to_replace_AssetCondition
branch
from
85dacdb
to
5fe2c2d
Compare
OwenKephart
force-pushed
the
04-30-Move_serialized_objects_to_separate_file
branch
from
b80f8c8
to
6bb5eff
Compare
OwenKephart
force-pushed
the
04-30-Create_SchedulingCondition_object_to_replace_AssetCondition
branch
from
5fe2c2d
to
0902a81
Compare
schrockn
reviewed
May 2, 2024
| from .scheduling_context import SchedulingContext | ||
|
|
||
|
|
||
| class SchedulingCondition(ABC, DagsterModel): |
There was a problem hiding this comment.
Might consider naming the ABC ISchedulingCondition or something because I will assume you will want a concrete SchedulingCondition later.
schrockn
approved these changes
May 2, 2024
OwenKephart
force-pushed
the
04-30-Move_serialized_objects_to_separate_file
branch
from
6bb5eff
to
8915abe
Compare
OwenKephart
force-pushed
the
04-30-Create_SchedulingCondition_object_to_replace_AssetCondition
branch
from
0902a81
to
9505365
Compare
OwenKephart
force-pushed
the
04-30-Move_serialized_objects_to_separate_file
branch
from
8915abe
to
3a89a5a
Compare
OwenKephart
force-pushed
the
04-30-Create_SchedulingCondition_object_to_replace_AssetCondition
branch
from
9505365
to
2a6363d
Compare
OwenKephart
force-pushed
the
04-30-Move_serialized_objects_to_separate_file
branch
from
3a89a5a
to
58fffcd
Compare
OwenKephart
force-pushed
the
04-30-Create_SchedulingCondition_object_to_replace_AssetCondition
branch
from
2a6363d
to
087d087
Compare
OwenKephart
force-pushed
the
04-30-Move_serialized_objects_to_separate_file
branch
from
d7a24af
to
e83b8dc
Compare
OwenKephart
force-pushed
the
04-30-Create_SchedulingCondition_object_to_replace_AssetCondition
branch
from
99e8c49
to
122d0d4
Compare
This was referenced May 3, 2024
OwenKephart
force-pushed
the
04-30-Move_serialized_objects_to_separate_file
branch
from
e83b8dc
to
acdf595
Compare
OwenKephart
force-pushed
the
04-30-Create_SchedulingCondition_object_to_replace_AssetCondition
branch
from
122d0d4
to
b962b89
Compare
Merge activity
|
OwenKephart
force-pushed
the
04-30-Move_serialized_objects_to_separate_file
branch
from
acdf595
to
9d4e494
Compare
Base automatically changed from
04-30-Move_serialized_objects_to_separate_file
to
master
May 3, 2024 22:10
OwenKephart
force-pushed
the
04-30-Create_SchedulingCondition_object_to_replace_AssetCondition
branch
from
b962b89
to
8d0118f
Compare
OwenKephart
deleted the
04-30-Create_SchedulingCondition_object_to_replace_AssetCondition
branch
cmpadden
pushed a commit
that referenced
this pull request
May 6, 2024
#21540) ## Summary & Motivation Create a SchedulingCondition object which serves as a base class for AssetCondition (which will be removed entirely in the future). Replaces most uses of AssetCondition with SchedulingCondition across the codebase ## How I Tested These Changes
This was referenced May 6, 2024
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
dagster-io#21540) ## Summary & Motivation Create a SchedulingCondition object which serves as a base class for AssetCondition (which will be removed entirely in the future). Replaces most uses of AssetCondition with SchedulingCondition across the codebase ## How I Tested These Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Create a SchedulingCondition object which serves as a base class for AssetCondition (which will be removed entirely in the future).
Replaces most uses of AssetCondition with SchedulingCondition across the codebase
How I Tested These Changes