Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DS][13/n] Convert SchedulingContext to DagsterModel #21521

Merged
merged 1 commit into from
May 3, 2024
Merged

[DS][13/n] Convert SchedulingContext to DagsterModel #21521

merged 1 commit into from
May 3, 2024

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

Makes a couple changes to allow using the DagsterModel class instead of dataclass

How I Tested These Changes

@OwenKephart OwenKephart mentioned this pull request Apr 30, 2024
Merged
@OwenKephart Graphite App
Copy link
Contributor Author

OwenKephart commented Apr 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite Graphite

@OwenKephart OwenKephart changed the title [13/n] Convert SchedulingContext to DagsterModel [DS][13/n] Convert SchedulingContext to DagsterModel Apr 30, 2024
This was referenced Apr 30, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@OwenKephart OwenKephart force-pushed the 04-30-Rename_SchedulingContext_object branch from 49f9edb to ab1644d Compare April 30, 2024 23:32
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from b130055 to 4c6fcb3 Compare April 30, 2024 23:32
@OwenKephart OwenKephart force-pushed the 04-30-Rename_SchedulingContext_object branch from ab1644d to 08ca1f2 Compare May 1, 2024 16:34
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from 4c6fcb3 to 4377a0a Compare May 1, 2024 16:34
@OwenKephart OwenKephart force-pushed the 04-30-Rename_SchedulingContext_object branch from 08ca1f2 to 773f6e6 Compare May 1, 2024 22:56
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from 4377a0a to 9315240 Compare May 1, 2024 22:56
@OwenKephart OwenKephart mentioned this pull request May 1, 2024
Merged
@OwenKephart OwenKephart force-pushed the 04-30-Rename_SchedulingContext_object branch from 773f6e6 to 04b4d42 Compare May 1, 2024 23:02
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from 9315240 to 7907df9 Compare May 1, 2024 23:02
schrockn
schrockn reviewed May 2, 2024
View reviewed changes
python_modules/dagster/dagster/_core/definitions/declarative_scheduling/asset_condition.py
@@ -199,7 +200,7 @@ class AssetConditionEvaluationState:
previous_tick_evaluation_timestamp: Optional[float]

max_storage_id: Optional[int]
extra_state_by_unique_id: Mapping[str, PackableValue]
extra_state_by_unique_id: Mapping[str, Any]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm this seems like a regression. What is going on here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally like to leave comments in code saying intent is to type it later just in case a stack gets caught in limbo for awhile

schrockn
schrockn requested changes May 2, 2024
View reviewed changes
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discuss comment

@OwenKephart OwenKephart force-pushed the 04-30-Rename_SchedulingContext_object branch from 04b4d42 to ddbe7a3 Compare May 2, 2024 19:52
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from 7907df9 to 497e409 Compare May 2, 2024 19:53
@OwenKephart OwenKephart force-pushed the 04-30-Rename_SchedulingContext_object branch from ddbe7a3 to f35ea1d Compare May 2, 2024 22:16
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from 497e409 to 8cc12c3 Compare May 2, 2024 22:17
@OwenKephart OwenKephart mentioned this pull request May 2, 2024
Merged
@OwenKephart OwenKephart force-pushed the 04-30-Rename_SchedulingContext_object branch from f35ea1d to a450d79 Compare May 2, 2024 22:58
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from 8cc12c3 to 67f0c6b Compare May 2, 2024 22:58
@OwenKephart OwenKephart mentioned this pull request May 3, 2024
Merged
@OwenKephart OwenKephart force-pushed the 04-30-Rename_SchedulingContext_object branch from 3ddbca0 to 1e241ac Compare May 3, 2024 16:58
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from c20d79b to 785b96e Compare May 3, 2024 16:58
This was referenced May 3, 2024
Merged
Merged
@OwenKephart OwenKephart force-pushed the 04-30-Rename_SchedulingContext_object branch from 1e241ac to c78c8ea Compare May 3, 2024 21:11
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from 785b96e to 05df5d1 Compare May 3, 2024 21:11
@OwenKephart Graphite App
Copy link
Contributor Author

OwenKephart commented May 3, 2024 •
edited
Loading

Merge activity

  • May 3, 5:31 PM EDT: @OwenKephart started a stack merge that includes this pull request via Graphite.
  • May 3, 5:57 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 3, 5:58 PM EDT: @OwenKephart merged this pull request with Graphite.

@OwenKephart OwenKephart force-pushed the 04-30-Rename_SchedulingContext_object branch from c78c8ea to 044df2c Compare May 3, 2024 21:54
Base automatically changed from 04-30-Rename_SchedulingContext_object to master May 3, 2024 21:56
@OwenKephart OwenKephart force-pushed the 04-30-Convert_SchedulingContext_to_DagsterModel branch from 05df5d1 to abcee61 Compare May 3, 2024 21:57
@OwenKephart OwenKephart merged commit acfb239 into master May 3, 2024
1 check was pending
@OwenKephart OwenKephart deleted the 04-30-Convert_SchedulingContext_to_DagsterModel branch May 3, 2024 21:58
@OwenKephart OwenKephart mentioned this pull request May 3, 2024
Merged
cmpadden pushed a commit that referenced this pull request May 6, 2024
@OwenKephart @cmpadden
[DS][13/n] Convert SchedulingContext to DagsterModel (#21521)
5535f1b 
## Summary & Motivation

Makes a couple changes to allow using the DagsterModel class instead of dataclass

## How I Tested These Changes
This was referenced May 6, 2024
Closed
Merged
Merged
Merged
Merged
Draft
Merged
Merged
Merged
Merged
Merged
Merged
Merged
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
@OwenKephart @danielgafni
[DS][13/n] Convert SchedulingContext to DagsterModel (dagster-io#21521)
c8a748d 
## Summary & Motivation

Makes a couple changes to allow using the DagsterModel class instead of dataclass

## How I Tested These Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schrockn schrockn schrockn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OwenKephart @schrockn