Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DS][37/n] Reorganize AssetGraphView methods #21739

Merged
merged 1 commit into from
May 14, 2024

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

As title -- just sorts the methods a bit to make thigns with similar purposes be next to each other. Also adds cached_method decorators to a few methods and adds a * to their type signatures (cached method does not support positional arguments)

How I Tested These Changes

Copy link
Contributor Author

OwenKephart commented May 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite Graphite

@OwenKephart OwenKephart force-pushed the 05-07-Create_RecentlyRequested_condition branch from 0d35118 to 0fd4a9d Compare May 9, 2024 22:48
@OwenKephart OwenKephart force-pushed the 05-08-Reorganize_AssetGraphView_methods branch from e71a53c to 7077f2f Compare May 9, 2024 22:48
@OwenKephart OwenKephart force-pushed the 05-07-Create_RecentlyRequested_condition branch from 0fd4a9d to 1bbbd9a Compare May 9, 2024 23:21
@OwenKephart OwenKephart force-pushed the 05-08-Reorganize_AssetGraphView_methods branch from 7077f2f to 1d1a561 Compare May 9, 2024 23:21
@OwenKephart OwenKephart force-pushed the 05-07-Create_RecentlyRequested_condition branch from 1bbbd9a to 3174f9a Compare May 10, 2024 22:14
@OwenKephart OwenKephart force-pushed the 05-08-Reorganize_AssetGraphView_methods branch from 1d1a561 to 4ba6d1e Compare May 10, 2024 22:14
@OwenKephart OwenKephart force-pushed the 05-07-Create_RecentlyRequested_condition branch from 3174f9a to 6dae5df Compare May 10, 2024 22:44
@OwenKephart OwenKephart force-pushed the 05-08-Reorganize_AssetGraphView_methods branch from 4ba6d1e to a6c4b42 Compare May 10, 2024 22:44
@OwenKephart OwenKephart changed the title [DS][36/n] Reorganize AssetGraphView methods [DS][37/n] Reorganize AssetGraphView methods May 10, 2024
@OwenKephart OwenKephart force-pushed the 05-07-Create_RecentlyRequested_condition branch from 6dae5df to c9aee95 Compare May 13, 2024 17:30
@OwenKephart OwenKephart force-pushed the 05-08-Reorganize_AssetGraphView_methods branch from a6c4b42 to 9a22020 Compare May 13, 2024 17:30
@OwenKephart OwenKephart force-pushed the 05-07-Create_RecentlyRequested_condition branch from c9aee95 to 8ede4ae Compare May 13, 2024 17:54
@OwenKephart OwenKephart force-pushed the 05-08-Reorganize_AssetGraphView_methods branch from 9a22020 to b801b27 Compare May 13, 2024 17:54
@OwenKephart OwenKephart force-pushed the 05-07-Create_RecentlyRequested_condition branch from 8ede4ae to 5823a56 Compare May 14, 2024 13:48
@OwenKephart OwenKephart force-pushed the 05-08-Reorganize_AssetGraphView_methods branch from b801b27 to a049e0a Compare May 14, 2024 13:48
@OwenKephart OwenKephart force-pushed the 05-07-Create_RecentlyRequested_condition branch from 5823a56 to e704541 Compare May 14, 2024 13:56
@OwenKephart OwenKephart force-pushed the 05-08-Reorganize_AssetGraphView_methods branch from a049e0a to 3b1358f Compare May 14, 2024 13:56
@OwenKephart OwenKephart force-pushed the 05-07-Create_RecentlyRequested_condition branch from e704541 to 91e489e Compare May 14, 2024 13:59
@OwenKephart OwenKephart force-pushed the 05-08-Reorganize_AssetGraphView_methods branch from 3b1358f to 79326eb Compare May 14, 2024 13:59
@OwenKephart OwenKephart force-pushed the 05-07-Create_RecentlyRequested_condition branch from 91e489e to bd76584 Compare May 14, 2024 14:14
@OwenKephart OwenKephart force-pushed the 05-08-Reorganize_AssetGraphView_methods branch from 79326eb to b9597c6 Compare May 14, 2024 14:14
Copy link
Contributor Author

OwenKephart commented May 14, 2024

Merge activity

  • May 14, 10:38 AM EDT: @OwenKephart started a stack merge that includes this pull request via Graphite.
  • May 14, 11:09 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 14, 11:10 AM EDT: @OwenKephart merged this pull request with Graphite.

@OwenKephart OwenKephart force-pushed the 05-07-Create_RecentlyRequested_condition branch from bd76584 to 55b9187 Compare May 14, 2024 15:05
Base automatically changed from 05-07-Create_RecentlyRequested_condition to master May 14, 2024 15:07
@OwenKephart OwenKephart force-pushed the 05-08-Reorganize_AssetGraphView_methods branch from b9597c6 to f7530a4 Compare May 14, 2024 15:08
@OwenKephart OwenKephart merged commit f6a85eb into master May 14, 2024
1 check was pending
@OwenKephart OwenKephart deleted the 05-08-Reorganize_AssetGraphView_methods branch May 14, 2024 15:10
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
## Summary & Motivation

As title -- just sorts the methods a bit to make thigns with similar purposes be next to each other. Also adds cached_method decorators to a few methods and adds a * to their type signatures (cached method does not support positional arguments)

## How I Tested These Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants