-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DS][37/n] Reorganize AssetGraphView methods #21739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2024
This was referenced May 9, 2024
schrockn
approved these changes
May 9, 2024
OwenKephart
force-pushed
the
05-07-Create_RecentlyRequested_condition
branch
from
May 9, 2024 22:48
0d35118
to
0fd4a9d
Compare
OwenKephart
force-pushed
the
05-08-Reorganize_AssetGraphView_methods
branch
from
May 9, 2024 22:48
e71a53c
to
7077f2f
Compare
OwenKephart
force-pushed
the
05-07-Create_RecentlyRequested_condition
branch
from
May 9, 2024 23:21
0fd4a9d
to
1bbbd9a
Compare
OwenKephart
force-pushed
the
05-08-Reorganize_AssetGraphView_methods
branch
from
May 9, 2024 23:21
7077f2f
to
1d1a561
Compare
OwenKephart
force-pushed
the
05-07-Create_RecentlyRequested_condition
branch
from
May 10, 2024 22:14
1bbbd9a
to
3174f9a
Compare
OwenKephart
force-pushed
the
05-08-Reorganize_AssetGraphView_methods
branch
from
May 10, 2024 22:14
1d1a561
to
4ba6d1e
Compare
OwenKephart
force-pushed
the
05-07-Create_RecentlyRequested_condition
branch
from
May 10, 2024 22:44
3174f9a
to
6dae5df
Compare
OwenKephart
force-pushed
the
05-08-Reorganize_AssetGraphView_methods
branch
from
May 10, 2024 22:44
4ba6d1e
to
a6c4b42
Compare
OwenKephart
changed the title
[DS][36/n] Reorganize AssetGraphView methods
[DS][37/n] Reorganize AssetGraphView methods
May 10, 2024
OwenKephart
force-pushed
the
05-07-Create_RecentlyRequested_condition
branch
from
May 13, 2024 17:30
6dae5df
to
c9aee95
Compare
OwenKephart
force-pushed
the
05-08-Reorganize_AssetGraphView_methods
branch
from
May 13, 2024 17:30
a6c4b42
to
9a22020
Compare
OwenKephart
force-pushed
the
05-07-Create_RecentlyRequested_condition
branch
from
May 13, 2024 17:54
c9aee95
to
8ede4ae
Compare
OwenKephart
force-pushed
the
05-08-Reorganize_AssetGraphView_methods
branch
from
May 13, 2024 17:54
9a22020
to
b801b27
Compare
OwenKephart
force-pushed
the
05-07-Create_RecentlyRequested_condition
branch
from
May 14, 2024 13:48
8ede4ae
to
5823a56
Compare
OwenKephart
force-pushed
the
05-08-Reorganize_AssetGraphView_methods
branch
from
May 14, 2024 13:48
b801b27
to
a049e0a
Compare
OwenKephart
force-pushed
the
05-07-Create_RecentlyRequested_condition
branch
from
May 14, 2024 13:56
5823a56
to
e704541
Compare
OwenKephart
force-pushed
the
05-08-Reorganize_AssetGraphView_methods
branch
from
May 14, 2024 13:56
a049e0a
to
3b1358f
Compare
OwenKephart
force-pushed
the
05-07-Create_RecentlyRequested_condition
branch
from
May 14, 2024 13:59
e704541
to
91e489e
Compare
OwenKephart
force-pushed
the
05-08-Reorganize_AssetGraphView_methods
branch
from
May 14, 2024 13:59
3b1358f
to
79326eb
Compare
OwenKephart
force-pushed
the
05-07-Create_RecentlyRequested_condition
branch
from
May 14, 2024 14:14
91e489e
to
bd76584
Compare
OwenKephart
force-pushed
the
05-08-Reorganize_AssetGraphView_methods
branch
from
May 14, 2024 14:14
79326eb
to
b9597c6
Compare
Merge activity
|
OwenKephart
force-pushed
the
05-07-Create_RecentlyRequested_condition
branch
from
May 14, 2024 15:05
bd76584
to
55b9187
Compare
Base automatically changed from
05-07-Create_RecentlyRequested_condition
to
master
May 14, 2024 15:07
OwenKephart
force-pushed
the
05-08-Reorganize_AssetGraphView_methods
branch
from
May 14, 2024 15:08
b9597c6
to
f7530a4
Compare
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
## Summary & Motivation As title -- just sorts the methods a bit to make thigns with similar purposes be next to each other. Also adds cached_method decorators to a few methods and adds a * to their type signatures (cached method does not support positional arguments) ## How I Tested These Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As title -- just sorts the methods a bit to make thigns with similar purposes be next to each other. Also adds cached_method decorators to a few methods and adds a * to their type signatures (cached method does not support positional arguments)
How I Tested These Changes