Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DS][2/n] Update signature of AutoMaterializeRule #21500

Merged
merged 1 commit into from
May 3, 2024

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

Continues work from the PR below, just banishing more traces of the AssetConditionEvaluationContext

How I Tested These Changes

@OwenKephart OwenKephart changed the title Update signature of AutoMaterializeRule [DS][2/n] Update signature of AutoMaterializeRule Apr 29, 2024
@OwenKephart OwenKephart force-pushed the Create_SchedulingConditionEvaluationContext branch from 7f96344 to e16d38d Compare April 30, 2024 15:52
@OwenKephart OwenKephart force-pushed the 04-29-Update_signature_of_AutoMaterializeRule branch from 257ed0b to d5962df Compare April 30, 2024 15:52
@OwenKephart OwenKephart force-pushed the Create_SchedulingConditionEvaluationContext branch from e16d38d to ffcd762 Compare April 30, 2024 23:31
@OwenKephart OwenKephart force-pushed the 04-29-Update_signature_of_AutoMaterializeRule branch from d5962df to bca70e1 Compare April 30, 2024 23:31
@OwenKephart OwenKephart force-pushed the Create_SchedulingConditionEvaluationContext branch from ffcd762 to 424c7a2 Compare May 1, 2024 16:33
@OwenKephart OwenKephart force-pushed the 04-29-Update_signature_of_AutoMaterializeRule branch from bca70e1 to 8c6f310 Compare May 1, 2024 16:33
Copy link
Contributor Author

OwenKephart commented May 3, 2024

Merge activity

  • May 3, 5:31 PM EDT: @OwenKephart started a stack merge that includes this pull request via Graphite.
  • May 3, 5:34 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 3, 5:35 PM EDT: @OwenKephart merged this pull request with Graphite.

Base automatically changed from Create_SchedulingConditionEvaluationContext to master May 3, 2024 21:33
@OwenKephart OwenKephart force-pushed the 04-29-Update_signature_of_AutoMaterializeRule branch from 782299e to 9860697 Compare May 3, 2024 21:33
@OwenKephart OwenKephart merged commit 8af99a3 into master May 3, 2024
1 check was pending
@OwenKephart OwenKephart deleted the 04-29-Update_signature_of_AutoMaterializeRule branch May 3, 2024 21:35
cmpadden pushed a commit that referenced this pull request May 6, 2024
## Summary & Motivation

Continues work from the PR below, just banishing more traces of the AssetConditionEvaluationContext

## How I Tested These Changes
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
## Summary & Motivation

Continues work from the PR below, just banishing more traces of the AssetConditionEvaluationContext

## How I Tested These Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants