Skip to content

fix: repair first-run onboarding path - #2465

Merged
yohamta0 merged 3 commits into
mainfrom
agent/fix-onboarding-paths
Jul 31, 2026
Merged

fix: repair first-run onboarding path#2465
yohamta0 merged 3 commits into
mainfrom
agent/fix-onboarding-paths

Conversation

@yohamta0

@yohamta0 yohamta0 commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • repair README quickstart commands and YAML so a locally created workflow appears in the Web UI and every workflow-shaped example validates
  • support runtime expressions for state.expected_version while preserving validation for integer, numeric-string, and invalid literal values
  • preserve the current DAG filename when rendering step and lifecycle status tables so Web UI log links target the correct workflow
  • fix the profiles keyboard-handler type error found while validating the frontend

Related onboarding updates were published directly to the companion repositories:

Root causes

The binary quickstart created hello.yaml in the current directory but started Dagu against its default DAG directory, so the workflow did not appear in the Web UI. Several copied examples also had schema or output mismatches. Separately, the status view spread the default DAG context over its explicit props, producing log URLs with an empty DAG filename.

Testing

  • make fmt
  • make bin
  • go test ./internal/cmd ./internal/runtime/builtin/state -count=1
  • make conformance CONFORMANCE_TEST_TARGET=./conformance/spec002_schema
  • cd ui && pnpm typecheck
  • cd ui && pnpm test -- src/features/dags/components/__tests__/DAGStatus.test.tsx (115 files / 490 tests passed)
  • validated 781 workflow examples from the docs repository; 9 explicitly contextual, intentionally invalid, or cross-repository pending examples were skipped
  • browser smoke test: confirmed all five generated examples appear, ran example-01-basic-sequential successfully, verified step log URLs include the DAG filename, and opened the stdout log drawer

Copilot AI review requested due to automatic review settings July 31, 2026 08:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PR adds runtime-expression support for state.expected_version, passes DAG filenames directly to NodeStatusTable, updates README workflow examples, and broadens the profile tab keyboard event type.

Changes

State expression validation

Layer / File(s) Summary
State expected version expressions
internal/runtime/builtin/state/config.go, internal/runtime/builtin/state/state.go, internal/cmd/validate_test.go, internal/runtime/builtin/state/state_test.go
expected_version accepts integer values, numeric strings, and exact runtime expressions. Validation tests cover valid and invalid values.

DAG status prop wiring

Layer / File(s) Summary
Explicit node table filename
ui/src/features/dags/components/DAGStatus.tsx, ui/src/features/dags/components/__tests__/DAGStatus.test.tsx
DAGStatus passes fileName directly to NodeStatusTable and removes the surrounding context consumer. Tests verify the prop.

Workflow documentation updates

Layer / File(s) Summary
Workflow examples and commands
README.md
README examples use explicit DAG directory targeting, updated output syntax, a single ETL workflow with dependencies, and a quoted templated URL.

Profile keyboard event typing

Layer / File(s) Summary
Broader keyboard event type
ui/src/pages/profiles/index.tsx
handleTabKeyDown accepts React.KeyboardEvent<HTMLElement> while preserving tab navigation behavior.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: fixing the first-run onboarding path.
Description check ✅ Passed The description explains the changes, root causes, related updates, and testing, but it omits the template's Changes and Checklist sections.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/fix-onboarding-paths

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yohamta0
yohamta0 marked this pull request as ready for review July 31, 2026 08:31
Copilot AI review requested due to automatic review settings July 31, 2026 08:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@yohamta0

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@internal/runtime/builtin/state/state.go`:
- Around line 117-127: Align expected_version handling between validateStep in
state.go and the config decoding logic in config.go: do not defer literal string
versions unless they are runtime expressions, or otherwise add consistent
parsing into config.ExpectedVersion as *int64. Ensure valid non-zero expected
versions remain available to runtime validation, and apply the corresponding
change at both referenced sites.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dca792ae-16a9-448a-a903-edc91fedd648

📥 Commits

Reviewing files that changed from the base of the PR and between 8f1f566 and 22daa59.

📒 Files selected for processing (8)
  • README.md
  • internal/cmd/validate_test.go
  • internal/runtime/builtin/state/config.go
  • internal/runtime/builtin/state/state.go
  • internal/runtime/builtin/state/state_test.go
  • ui/src/features/dags/components/DAGStatus.tsx
  • ui/src/features/dags/components/__tests__/DAGStatus.test.tsx
  • ui/src/pages/profiles/index.tsx

Comment thread internal/runtime/builtin/state/state.go
Copilot AI review requested due to automatic review settings July 31, 2026 08:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@yohamta0

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@yohamta0
yohamta0 merged commit a1a3c28 into main Jul 31, 2026
14 checks passed
@yohamta0
yohamta0 deleted the agent/fix-onboarding-paths branch July 31, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants