Skip to content

feat: Implement DataAnnotationsStreamQueryInterceptor (BCL validation for stream queries)#409

Merged
samtrion merged 1 commit into
mainfrom
copilot/add-dataannotations-stream-query-interceptor
Apr 16, 2026
Merged

feat: Implement DataAnnotationsStreamQueryInterceptor (BCL validation for stream queries)#409
samtrion merged 1 commit into
mainfrom
copilot/add-dataannotations-stream-query-interceptor

Conversation

Copilot AI commented Apr 16, 2026

Copy link
Copy Markdown
Contributor
  • Create DataAnnotationsStreamQueryInterceptor<TQuery, TResponse> in src/NetEvolve.Pulse/Interceptors/
  • Update DataAnnotationsExtensions.AddDataAnnotations() to register IStreamQueryInterceptor<,> alongside existing request and event interceptors
  • Update XML docs on DataAnnotationsExtensions to mention stream queries
  • Create unit tests in tests/NetEvolve.Pulse.Tests.Unit/DataAnnotations/Interceptors/DataAnnotationsStreamQueryInterceptorTests.cs
  • Update DataAnnotationsExtensionsTests.cs to test stream query interceptor registration and idempotency
  • Resolve merge conflicts with main (which added DataAnnotationsEventInterceptor) — all three interceptors (request, stream query, event) are now registered in AddDataAnnotations()
  • Build succeeds with zero errors and zero warnings

Copilot AI changed the title [WIP] Implement DataAnnotationsStreamQueryInterceptor for BCL validation feat: Implement DataAnnotationsStreamQueryInterceptor (BCL validation for stream queries) Apr 16, 2026
Copilot AI requested a review from samtrion April 16, 2026 16:36
@samtrion
samtrion marked this pull request as ready for review April 16, 2026 16:57
@samtrion
samtrion requested a review from a team as a code owner April 16, 2026 16:57
@samtrion
samtrion force-pushed the copilot/add-dataannotations-stream-query-interceptor branch from b2399c2 to b1f4480 Compare April 16, 2026 20:50
@codecov

codecov Bot commented Apr 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.30%. Comparing base (b901aac) to head (9b840e3).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...erceptors/DataAnnotationsStreamQueryInterceptor.cs 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
+ Coverage   91.87%   92.30%   +0.42%     
==========================================
  Files         144      145       +1     
  Lines        5431     5448      +17     
  Branches      508      512       +4     
==========================================
+ Hits         4990     5029      +39     
+ Misses        296      272      -24     
- Partials      145      147       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samtrion

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in 5bacace. The conflict in DataAnnotationsExtensions.cs was between my stream query interceptor registration and the event interceptor registration added in main — both are now included alongside the existing request interceptor.

…y BCL validation

Agent-Logs-Url: https://github.com/dailydevops/pulse/sessions/095324d1-ae26-476a-bdba-57b2ba12bfa4

Co-authored-by: samtrion <3283596+samtrion@users.noreply.github.com>
@samtrion
samtrion force-pushed the copilot/add-dataannotations-stream-query-interceptor branch from 5bacace to 9b840e3 Compare April 16, 2026 21:23
@samtrion
samtrion merged commit 42dd600 into main Apr 16, 2026
11 checks passed
@samtrion
samtrion deleted the copilot/add-dataannotations-stream-query-interceptor branch April 16, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Implement DataAnnotationsStreamQueryInterceptor (BCL validation for stream queries)

2 participants