feat(ads): add measurement tags to Ad contract#6310
Merged
Conversation
Extend the skadi Ad signature with an optional tags[] array carrying third-party measurement tags (CM360 JS/iframe, DoubleVerify) that cannot run natively under the extension MV3 CSP. Each tag holds raw markup with macros unsubstituted plus an overlay flag indicating whether it must cover the creative (viewability geometry). Execution stays client-decided: inline on web, single web-origin frame on the extension.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Removed comments regarding third-party measurement tags from the AdMeasurementTag interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extends the skadi `Ad` signature with third-party measurement support for enterprise advertisers (CM360 JS/iframe tags, DoubleVerify viewability/IVT/suitability).
```ts
export interface Ad {
// ...
tags?: AdMeasurementTag[];
}
export interface AdMeasurementTag {
markup: string; // raw tag HTML, macros unsubstituted
overlay?: boolean; // frame must cover the creative (e.g. DV viewability)
}
```
Why this shape
Scope
Signature only. Rendering (native macro substitution on web, the web-origin measurement frame on the extension) lands in follow-ups. Coordinate with the ad-server team so skadi populates `tags[]` accordingly.
Ref: `plans/cm360-doubleverify-support.md`
Preview domain
https://feat-ad-measurement-tags-signatu.preview.app.daily.dev