Skip to content

fix(sentiment): hide sources with no comments#6371

Merged
rebelchris merged 1 commit into
mainfrom
codex/hide-empty-sentiment-sources
Jul 23, 2026
Merged

fix(sentiment): hide sources with no comments#6371
rebelchris merged 1 commit into
mainfrom
codex/hide-empty-sentiment-sources

Conversation

@rebelchris

@rebelchris rebelchris commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Hide per-community sentiment rows when the matched source discussion has zero comments
  • Keep the rest of the sentiment breakdown visible when only one source has no comments
  • Update regression coverage for the zero-comment source case

Testing

  • NODE_ENV=test node_modules/.bin/jest src/components/post/focus/CommunitySentimentBreakdown.spec.tsx --runInBand
  • node ./scripts/typecheck-strict-changed.js
  • node_modules/.bin/prettier --check src/components/post/focus/CommunitySentimentBreakdown.tsx src/components/post/focus/CommunitySentimentBreakdown.spec.tsx
  • git diff --check
  • NODE_ENV=test node_modules/.bin/jest --runInBand (webapp)

Preview domain

https://codex-hide-empty-sentiment-sourc.preview.app.daily.dev

@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Jul 23, 2026 3:01pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Jul 23, 2026 3:01pm

Request Review

@rebelchris
rebelchris force-pushed the codex/hide-empty-sentiment-sources branch from 332d523 to c12dc13 Compare July 23, 2026 14:58
@rebelchris
rebelchris merged commit 5fc53d3 into main Jul 23, 2026
12 checks passed
@rebelchris
rebelchris deleted the codex/hide-empty-sentiment-sources branch July 23, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant