feat(layout-v2): give the rail its own Home button - #6572
Merged
Conversation
The brand mark used to be the way home, crossfading into a home glyph whenever the pointer touched the rail. That put the destination behind a hover: at rest nothing on the rail said "home", and the mark changed shape under a pointer that was only passing through on its way to a tab. The logo is a logo again. It stays the daily.dev mark at all times, its tooltip names the product rather than a destination, and Home is now a button of its own between it and Search, with the same resting and active treatment as every other rail control. Clicking either still lands on the same feed, so the mark keeps its familiar click. Both share one handler because the extension's onLogoClick defaults the event and switches the feed in place; letting Home's handler run after that would overwrite it with the default feed. `group/rail` on the nav existed only to drive the crossfade, so it goes with it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rebelchris
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverses the home affordance introduced in #6406: the brand mark goes back to being a brand mark, and Home becomes a rail control of its own.
Why
#6406 made the daily.dev logo double as Home, crossfading into a home glyph whenever the pointer touched anywhere on the rail. That put the destination behind a hover. At rest nothing on the rail said "home", and the mark changed shape under a pointer that was only passing through on its way to a tab.
What changes
HomeIcon,secondarywhen active,aria-current="page").Both share one
onGoHomehandler. The extension'sonLogoClickdefaults the event and switches the feed in place (to My Feed on the new tab), so letting Home's handler run afterwards would overwrite that with the default feed. On the webapponLogoClickis undefined, so Home owns the click.group/railon the nav existed only to drive the crossfade, so it goes with it. Nothing else in the codebase consumesgroup-hover/railorgroup-focus-visible/rail.Note on timing
The commit dates from 8 Aug and sat on an unopened branch; this PR is it finally being raised. Current
mainhas been merged in, and it applied with no conflicts: nobody has touched this part of the rail since.Verification
typecheck-strict-changedand eslint cleanNo test asserted the old crossfade behaviour, so none needed updating.
🤖 Generated with Claude Code
Preview domain
https://claude-rail-home-button.preview.app.daily.dev