Derive Fintype for curve points computably - #11
Merged
Merged
Conversation
Upgrade the Finite instance for SWPoint to a computable Fintype. The subtype equivalence composed with the decidable Valid predicate makes the point enumeration a plain filter of F x F. The instance lives next to equivSubtype in ShortWeierstrass, upstream of the concrete curves. Named Pallas/Vesta instantiations pin the concrete enumerations in the trust census at the +choice tier. Choice enters only through erased Prop fields. The primality Facts are Pratt-certified, so no native trust is involved. Fixes #10. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
daira
force-pushed
the
computable-fintype
branch
from
July 21, 2026 19:53
69f3dd6 to
0b1cb3f
Compare
daira
marked this pull request as ready for review
July 22, 2026 02:39
daira
added a commit
to daira/ironwood
that referenced
this pull request
Jul 22, 2026
CompElliptic now derives Fintype for curve points computably (daira/CompElliptic#11). Bump the dependency and remove the Fintype.ofFinite materializations. globalReachSet and splitFamilyRand (both variants) become plain defs. The trust-boundary guards pass unchanged. The book's scoped-exception paragraph is removed. Fixes zcash#83. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10.
instFintypeSWPointmakesSWPoint Ecomputably finite whenever the base field is. The enumeration is a plain filter ofF × Funder the decidableValidpredicate. It lives inShortWeierstrass, next toequivSubtype, whose docstring already promised it.CurveOrder'sFiniteinstance is now derived, so it has been removed.The named
Pallas.fintypePoints/Vesta.fintypePointsinstantiations are pinned in the trust census withassert_computable +choice. Choice enters only through erasedPropfields of the MathlibFinsetlemmas. The primalityFacts are Pratt-certified, so the concrete instantiations carry nonative_decidetrust.The instance is parametric. A noncomputable
Fintype Fat some other use site would still resolve; it would merely make that use site noncomputable. ForZMod qthe dictionary is computable viaFin.zcash/ironwood#83 consumes this to make
globalReachSet/splitFamilyRandcomputable.🤖 Claude Fable 5