Remove dead parse_log_line public API (DSK-136)#177
Conversation
Drop unused parse_log_line/parse_log_line_bytes re-exports; benches exercise split_log_line and LogLineTimestampResolver on the hot path. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
Changes
Sequence Diagram(s)sequenceDiagram
participant Bench as bench_ingest_log_line
participant Splitter as split_log_line
participant Resolver as LogLineTimestampResolver
Bench->>Splitter: raw bytesを渡す
Splitter-->>Bench: (parsed, msg)を返す
Bench->>Resolver: resolve(parsed, msg)を呼ぶ
Resolver-->>Bench: (ts, message)を返す
重大度: Medium。公開APIの破壊的変更( Possibly related issues
🚥 Pre-merge checks | ❌ 2❌ Failed checks (2 warnings)
Comment |
Summary
parse_log_line/parse_log_line_bytesfrom the public crate API; production streaming already usessplit_log_lineinline.split_log_lineandLogLineTimestampResolver, re-exported under thebenchfeature.Test plan
cargo test -p rustern-core --lib source::pod_logcargo bench -p rustern-core --bench hot_path --features bench --no-runMade with Cursor
Summary by CodeRabbit