Conversation
…ith lifetimes and mutable/immutable conflicts. Saving so I can try something else.
This works for the tests in rule 145, not sure it will work for "divides" or other infix vertical bar rules. Remove some DEBUG() helpers
…n version of chars
SpeechRules can now be borrowed immutably, so cleaned that up Changed "comma" to use "," which is cleaned up later. Passes all current tests in Rules.
NSoiffer
pushed a commit
that referenced
this pull request
Jun 23, 2026
* first updates unicode, general and part of default * Test update * Updated geometry.yaml #2 * Updated linear-algebra and calculus #3 #4 * ClearSpeak_rules.yaml updated * Update overview.yaml Close #10 * Update navigate.yaml * Update SimpleSpeak_Rules.yaml * Update definitions.yaml Closes #14 * Updated SimpleSpeakl and ClearSpeak Finished the update of SimpleSpeak and corrected a rule in both SimpleSpeak and ClearSpeak that made mixed numbers be spoken incorrectly. * Bug fix in SimpleSpeak and ClearSpeak Fixed a bug concerning common fractions used in mixed numbers. * Fixed a bug in general.yaml Fixed a bug concerning how one is spoken in combination with a unit. * Unicode-full & navigate Updated unicode-full and navigate, plus fixed a couple of typos in the english unicode-full. * Fixed a corrupt file There was some problem with general.yaml, which should now be fixed. * Update default.yaml * Update general.yaml Hopefully this fix will solve a lot of the failed tests. #15 * Updated functions.rs Both for ClearSpeak and SimpleSpeak * Fixed a multiline test fail Both ClearSpeak_rules.yaml and multiline.rs needed an update. * Fixed linear-algebra fails Restored language-specific rules for homomorphism and kernel. * Tests updated Updated tests to conform to slight changes in speaking (pausing and 1/en) * Fixed some small errors * Bug fix * Update navigate.yaml * Fixed a language-dependent issue * Added audit-ignore to reintroduced rules * Fixed laplacian * Minor typo fix Added missing "bråk" to "slut bråk" announcement --------- Co-authored-by: AndersEkl <anders.eklund@spsm.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo of ContextStack. Now more efficient and more powerful in that variables whose values are nodes work.
Added a superstructure to that points to the context stack and speech rules. This allows the speech rules to be immutable during speech generation. Trying to do this caused the Rust memory checker to complain in several places. It took awhile, but I found the solution was to introduce a separate lifetime for the reference to the SpeechRulesWithContext from the lifetime of the ContextStack. Thus there are now three lifetimes that are tracked.
Also fixed a number of bugs.