Skip to content

fix more plurals of units #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moritz-gross merged 1 commit into from
Aug 6, 2026
+40 −2
Merged

fix more plurals of units #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions Rules/Languages/de/definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,32 @@
"byte": "byte", "baud": "baud",
"zoll": "zoll", "fuß": "füße", "meile": "meilen", "rute": "ruten",
"glied": "glieder", "kette": "ketten", "fass": "fässer", "gallone": "gallonen",
"quadratzoll": "quadratzoll", "quadratfuß": "quadratfüße", "quadratyard": "quadratyards",
"quadratmeile": "quadratmeilen", "morgen": "morgen", "brettfuß": "brettfüße",
"kubikzoll": "kubikzoll", "kubikfuß": "kubikfüße", "kubikyard": "kubikyards",
"buschelmaß": "buschelmaße", "buschel": "buschel", "teelöffel": "teelöffel",
"esslöffel": "esslöffel", "flüssige dram": "flüssige drams", "gill": "gills",
"tasse": "tassen", "pint": "pints", "quart": "quarts", "korn": "körner",
"dram": "drams", "unze": "unzen", "pfund": "pfund", "zentner": "zentner",
"feingewicht": "feingewichte", "troy-unze": "troy-unzen", "troy-pfund": "troy-pfund",
"ps": "ps", "britische wärmeeinheit": "britische wärmeeinheiten",
"grad fahrenheit": "grad fahrenheit",
"umdrehungen pro minute": "umdrehungen pro minute",
"meile pro stunde": "meilen pro stunde", "meile pro gallone": "meilen pro gallone"
"meile pro stunde": "meilen pro stunde", "meile pro gallone": "meilen pro gallone",

"minute": "minuten", "stunde": "stunden", "tag": "tage", "woche": "wochen",
"grad": "grade", "astronomische einheit": "astronomische einheiten",
"lichtjahr": "lichtjahre", "parsec": "parsec", "ångström": "ångström",
"fermi": "fermis", "hektar": "hektar", "dezibel": "dezibel",
"atmosphäre": "atmosphären", "bar": "bar", "kalorie": "kalorien", "curie": "curie",
"gon": "gon", "mol/liter": "mol/liter", "röntgen": "röntgen", "mho": "mho",
"dyn": "dyn", "erg": "erg",
"kibi-bit": "kibi-bit", "mebi-bit": "mebi-bit", "gibi-bit": "gibi-bit",
"tebi-bit": "tebi-bit", "pebi-bit": "pebi-bit", "exbi-bit": "exbi-bit",
"zebi-bit": "zebi-bit", "yobi-bit": "yobi-bit",
"kibi-byte": "kibi-byte", "mebi-byte": "mebi-byte", "gibi-byte": "gibi-byte",
"tebi-byte": "tebi-byte", "pebi-byte": "pebi-byte", "exbi-byte": "exbi-byte",
"zebi-byte": "zebi-byte", "yobi-byte": "yobi-byte",
"umdrehungen pro minute": "umdrehungen pro minute"
}


Expand Down
15 changes: 15 additions & 0 deletions tests/Languages/de/units.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,21 @@ fn english_rute_plural_regression() -> Result<()> {
Ok(())
}

#[test]
fn non_si_unit_plural_regression() -> Result<()> {
let expr = r#"<math>
<mn>1</mn><mi intent=":unit">h</mi><mo>,</mo><mn>2</mn><mi intent=":unit">h</mi><mo>,</mo>
<mn>1</mn><mi intent=":unit">d</mi><mo>,</mo><mn>2</mn><mi intent=":unit">d</mi><mo>,</mo>
<mn>1</mn><mi intent=":unit">w</mi><mo>,</mo><mn>2</mn><mi intent=":unit">w</mi><mo>,</mo>
<mn>1</mn><mi intent=":unit">pc</mi><mo>,</mo><mn>2</mn><mi intent=":unit">pc</mi><mo>,</mo>
<mn>1</mn><mi intent=":unit">ha</mi><mo>,</mo><mn>2</mn><mi intent=":unit">ha</mi><mo>,</mo>
<mn>1</mn><mi intent=":unit">Kib</mi><mo>,</mo><mn>2</mn><mi intent=":unit">Kib</mi>
</math>"#;
test("de", "SimpleSpeak", expr,
"1 stunde, komma 2 stunden, komma 1 tag komma 2 tage, komma 1 woche komma 2 wochen, komma 1 parsec, komma 2 parsec, komma 1 hektar, komma 2 hektar, komma 1 kibi-bit, komma 2 kibi-bit")?;
Ok(())
}

/*
#[test]
fn si_base_with_prefixes() -> Result<()> {
Expand Down
Loading