How to set line height/spacing

[p7cq]

Hi,

Setting default line height in Doom Emacs causes ghostel to vscroll up, hidding the first two lines.

With: (setq default-text-properties '(line-spacing 0.1 line-height 1.05))

Without setting custom line height and spacing:

SPC o T is slightly different:

• Shows the cursor left-justified, in the middle of the screen.

How to configure these two in ghostel?

[dakra]

I pushed a "fix" that simply sets (setq-local default-text-properties nil).

line-spacing > 0 is currently not really supported, but it also shouldn't break things (which it currently does).

Supporting the text-property is more difficult because Emacs window-screen-lines ignores line-height properties and that's what we currently use to size the terminal grid.

[p7cq]

Thanks, the patch fixes the vscroll/hidden prompt issue completely.

One follow-up on (setq-local line-spacing 0) - would it be reasonable to expose it as a user option, say ghostel-line-spacing (default preserving current behavior), purely for visual consistency in setups that enable the option globally?

[dakra]

That's exactly what we just added: 9a4256a

But be aware that this then breaks everything that tiles vertically (box-drawing, block characters, kitty image rows).

So I would not necessarily recommend it, but at least you can set it now.

[p7cq]

You're right, appearance would then be off, especially in btop/htop/progress bars, similar to (non-zero spacing, in Ghostel)

vs expected appearance (no spacing, in Ghostty)

(Some glyphs may not be rendered correctly, but that's due to my font config.)

It works however. I only tested in my current setup, Ghostel pinned by Doom @ 0f0a9bd, Emacs 30.2, manually adding 17b59d6 and 9a4256a into ghostel.el (patches won't apply cleanly on this version). Test config:

(setq my/line-spacing 0.2)
(setq! ghostel-line-spacing my/line-spacing)
(setq default-text-properties `(line-spacing ,my/line-spacing line-height 1.05))

I found out this also seems to work (without patches) on 0f0a9bd:

(add-hook! 'ghostel-mode-hook
  (setq-local default-text-properties nil
              line-spacing my/line-spacing))

Thank you, great work @dakra!