Entering Evil insert mode away from the buffer end after a process exits raises `NotOpenForWriting`

[Vonfry]

Description

When Ghostel is used from Eshell with Evil integration, entering Evil insert mode at an earlier position in the Ghostel buffer after the child process has exited causes Ghostel to try to write to the closed process channel.

The following error is displayed:

ghostel--send-encoded: ghostel: error in ghostel--encode-key: NotOpenForWriting

Steps to reproduce

1. Start Emacs and evaluate the following configuration:

   (require 'evil)
   (require 'ghostel)
   (require 'evil-ghostel)
   (require 'eshell)
   (require 'ghostel-eshell)
   (add-hook 'ghostel-mode-hook 'evil-ghostel-mode)
   (ghostel-eshell-visual-command-mode)
   (evil-mode)

2. Open Eshell.

3. Run:

   ghostel codex
   

4. After Codex has started, perform these actions in order:

   1. Type /exit.
   2. Press ESC to enter Evil normal mode.
   3. Press RET (Enter).
   4. Move the cursor upward into the initial messages near the beginning of the buffer.
   5. Wait for the Codex process to stop.
   6. Press a or i to enter Evil insert mode.

Actual behavior

Entering insert mode raises this error:

ghostel--send-encoded: ghostel: error in ghostel--encode-key: NotOpenForWriting

Workaround

Move the cursor to the end of the buffer before entering insert mode. No error occurs in that case, and pressing q closes the buffer.

Guess

Write a simple bash script

echo hello

sleep 5

echo world

After repeating the above steps, the issue isn't appeared. I guess this issue is
caused by some special escape charactels.

[dakra]

Can you try with the latest version?
It fixes a bug related to that but I'm not 100% sure if this was actually yours.

Also, what ghostel version and in what environment (Mac, Windows, Linux?) are you seeing this?

[Vonfry]

On the newest commit, the evil-ghostel-mode will cause error in ghostel buffer with following messages:

Error running timer ‘ghostel--redraw-now’: (wrong-number-of-arguments #<subr evil-ghostel--around-redraw> 4)
redisplay--pre-redisplay-functions: (wrong-number-of-arguments #<subr evil-ghostel--around-redraw> 4) [4 times]
error in process filter: apply: Wrong number of arguments: #<subr evil-ghostel--around-redraw>, 4
error in process filter: Wrong number of arguments: #<subr evil-ghostel--around-redraw>, 4

It breaks the emacs buffer redraw to show *Backtrace* as well if opening toggle-debug-on-error.
With a quick bisect, the error is introduced between 0.44.0 and the newest commit. Not the commit you mentioned.

My emacs version is 32.0.50 (2a2675fd3977b872d8c6b3efb8cc1d93c9e6b4fa) with pgtk and native comp.
My original report ghostel is 92bfcc57dc85f254ce95dcb51dbdd2411fea5f02.

[Vonfry]

I found the original issue has been fixed in 0.44.0 because the cursor moves to the editable area automatically.
But there is another issue is detected. You can either close this and open a new one, or keep this.

[dakra]

This looks like a version mismatch of ghostel and evil-ghostel.

Can you make sure you don't have any stale .elc and .eln files for it and then try to restart?
The version you had before was very old.

(EDIT: Since we posted exactly the same time. I was replying to your message before about the redraw error)

[dakra]

But there is another issue is detected

What is the issue?

[Vonfry]

This looks like a version mismatch of ghostel and evil-ghostel.
Can you make sure you don't have any stale .elc and .eln files for it and then try to restart?

It is my fault that wrong evil-ghostel is loaded. Sorry.

What is the issue?

No, it is all worked. Thanks!