Respect Zig install prefix for native module#502
Merged
Conversation
emil-e
force-pushed
the
fix/zig-install-prefix
branch
from
July 2, 2026 18:47
c80b750 to
776e19f
Compare
Vonfry
approved these changes
Jul 3, 2026
Vonfry
left a comment
There was a problem hiding this comment.
With a glance, LGTM. And it is tested on linux.
emil-e
force-pushed
the
fix/zig-install-prefix
branch
from
July 3, 2026 12:57
776e19f to
683ee19
Compare
emil-e
force-pushed
the
fix/zig-install-prefix
branch
from
July 3, 2026 13:34
683ee19 to
ca94ce9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--prefix .when checkout-root artifacts are expectedVerification
emacs --batch -Q -L lisp --eval '(setq byte-compile-error-on-warn t)' -f batch-byte-compile lisp/ghostel-module-install.elemacs --batch -Q -L lisp -L test --eval '(setq load-prefer-newer t)' -l ert -l test/ghostel-test-helpers.el -l test/ghostel-module-test.el --eval "(ert-run-tests-batch-and-exit '(not (tag native)))"zig build --prefix /private/tmp/ghostel-pr-prefix-test -Doptimize=Debug -Dcpu=baselinegit diff --check