Skip to content

Respect Zig install prefix for native module#502

Merged
emil-e merged 2 commits into
dakra:mainfrom
emil-e:fix/zig-install-prefix
Jul 3, 2026
Merged

Respect Zig install prefix for native module#502
emil-e merged 2 commits into
dakra:mainfrom
emil-e:fix/zig-install-prefix

Conversation

@emil-e

@emil-e emil-e commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • install the native module and version sidecar under Zig's install prefix instead of escaping it
  • update Makefile, CI/release builds, docs, and helper scripts to pass --prefix . when checkout-root artifacts are expected
  • keep Emacs auto-builds safe by building into a temporary prefix and renaming the module/sidecar into place

Verification

  • emacs --batch -Q -L lisp --eval '(setq byte-compile-error-on-warn t)' -f batch-byte-compile lisp/ghostel-module-install.el
  • emacs --batch -Q -L lisp -L test --eval '(setq load-prefer-newer t)' -l ert -l test/ghostel-test-helpers.el -l test/ghostel-module-test.el --eval "(ert-run-tests-batch-and-exit '(not (tag native)))"
  • zig build --prefix /private/tmp/ghostel-pr-prefix-test -Doptimize=Debug -Dcpu=baseline
  • git diff --check

@emil-e
emil-e force-pushed the fix/zig-install-prefix branch from c80b750 to 776e19f Compare July 2, 2026 18:47

@Vonfry Vonfry left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a glance, LGTM. And it is tested on linux.

Comment thread test/ghostel-module-test.el
@emil-e
emil-e force-pushed the fix/zig-install-prefix branch from 776e19f to 683ee19 Compare July 3, 2026 12:57
@emil-e
emil-e force-pushed the fix/zig-install-prefix branch from 683ee19 to ca94ce9 Compare July 3, 2026 13:34
@emil-e
emil-e merged commit 43dae23 into dakra:main Jul 3, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants