Bump libghostty and use upstream color parser#514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ghostty-org/ghosttydependency from07d3166toc41c6b8.print_slicestream action in the comint filter so printable text is not dropped.#RRGGBBparser withgt.color.RGB.parsewhere possible.Verification
zig build --prefix .zig build --prefix . -Doptimize=ReleaseFastbench/run-bench.sh --no-vterm --no-eat --no-termbackend/plain/nativewith--min-duration 3Benchmark summary
Compared against
4c6351f(parent before this branch's two commits). Both sides were rebuilt withzig build --prefix . -Doptimize=ReleaseFast.Selected results:
e2e/plain/ghostele2e/urls/ghostelstream/ghostel-increngine/plain/ghostel-incr/24x80engine/unicode/ghostel-incr/24x80The one reproducible regression is isolated to native PTY plain output:
backend/plain/native)This likely indicates the faster VT engine has moved the bottleneck to the native PTY read/event-notification path: plain parsing no longer provides as much incidental batching before
WouldBlock, so the reader may notify/redraw more often. Parser-only and stream-only paths show large wins, so this does not look like a raw VT parsing regression.