Move action.yml to repo root for Marketplace eligibility - #12
Merged
Conversation
GitHub Marketplace only discovers and lists an action whose action.yml sits at the repository root - a subdirectory copy (where ours lived, packages/action/action.yml, matching the monorepo's package layout) is valid for consumers who reference it via "uses: owner/repo/path@ref", but never shows up as listable on the Marketplace itself. Moved it to the root and updated runs.main from 'dist/index.js' to 'packages/action/dist/index.js', since the path is now resolved relative to the action's root (the repo root), not the subdirectory action.yml used to live in. The actual implementation stays under packages/action/ unchanged - only the metadata file's location and that one path moved. No other file referenced the old subdirectory path. Verified lint/typecheck/build all still pass.
The previous commit's git add invocation silently failed (passed a second pathspec, packages/action/action.yml, that no longer existed after the git mv, which aborted the whole add without adding anything) - so the actual path fix in the working tree never made it into the commit, even though it had already been applied and verified locally. Committing the real fix now: runs.main needs to be 'packages/action/dist/index.js', not the old 'dist/index.js', now that action.yml lives at the repo root instead of packages/action/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub Marketplace only discovers and lists an action whose
action.ymlsits at the repository root - our copy atpackages/action/action.yml(matching the monorepo layout) is valid for anyone referencing it viauses: owner/repo/path@ref, but would never show up as listable on the Marketplace itself.Moved
action.ymlto the root, updatedruns.mainfrom'dist/index.js'to'packages/action/dist/index.js'since the path is now resolved relative to the repo root instead of the old subdirectory. The actual implementation stays underpackages/action/unchanged - only the metadata file's location and that one path string moved.Test plan
npm run lint/typecheck/buildall passpackages/action/action.ymlpathruns.mainpath verified correct against standard GitHub Actions convention (path always relative to the directory containingaction.yml)