Fix streaming RPC cancel watcher lifetime#101
Closed
cursor[bot] wants to merge 2 commits into
Closed
Conversation
Co-authored-by: dallison <dallison@users.noreply.github.com>
Co-authored-by: dallison <dallison@users.noreply.github.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Streaming RPC handlers spawned detached cancel watcher coroutines that captured per-request
AnyStreamWriterandRpcRequeststack objects by reference. After a stream completed normally, the watcher could remain blocked on the cancel channel and later dereference freed stack state or consume cancellation messages for a different in-flight stream, causing crashes, memory corruption, or lost stream cancellation.Root cause
The cancel watcher lifetime was independent from the stream callback lifetime, while
AnyStreamWriteralso stored the request by reference.Fix
RpcRequestmetadata and use atomic cancellation state.rpc,asio_rpc,coro_rpc, andco20_rpcserver backends.Validation
npx --yes @bazel/bazelisk test //asio_rpc/server:server_test //coro_rpc/server:server_test //co20_rpc/server:server_test //rpc/server:server_test