Continue retrying downloads on retriable statuses

[jwodder]

Closes #1556.

[jwodder]

@yarikoptic Question: Shouldn't this check be at the top of the function? Otherwise, if we keep hitting, say, 500 responses, it'll keep retrying beyong the maximum number of attempts.

[yarikoptic]

indeed. But after potential increment of attempts_allowed in the "aggressive" mode.

[jwodder]

Fixed in bb05a23.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.53%. Comparing base (29009f6) to head (bb05a23).
Report is 92 commits behind head on master.

Files with missing lines	Patch %	Lines
dandi/download.py	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1558      +/-   ##
==========================================
+ Coverage   88.38%   88.53%   +0.14%     
==========================================
  Files          78       78              
  Lines       10736    10735       -1     
==========================================
+ Hits         9489     9504      +15     
+ Misses       1247     1231      -16     

Flag	Coverage Δ
unittests	87.75% <0.00%> (-0.63%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[yarikoptic]

I think this is legit, I want to propose further changes. Will follow up with a PR "shortly".

[github-actions]

🚀 PR was released in 0.66.4 🚀