Skip to content

BF: fix incompatibility with click >= 8.2.0 #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yarikoptic merged 1 commit into from
Oct 13, 2025
Merged

BF: fix incompatibility with click >= 8.2.0 #1723

yarikoptic merged 1 commit into from
Oct 13, 2025

Conversation

@yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Oct 13, 2025

Otherwise was failing as

  File "/home/yoh/proj/dandi/dandi-cli-enh-get-bibliography/.venv/lib/python3.11/site-packages/click/core.py", line 2215, in make_metavar
    metavar = self.type.get_metavar(param=self, ctx=ctx)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: LogLevel.get_metavar() got an unexpected keyword argument 'ctx'

@yarikoptic
[DATALAD RUNCMD] BF: fix incompatibility with click >= 8.2.0
38a79f7 
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi 'get_metavar(self, param)' 'get_metavar(self, param, ctx=None)'",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^

Otherwise was failing as

      File "/home/yoh/proj/dandi/dandi-cli-enh-get-bibliography/.venv/lib/python3.11/site-packages/click/core.py", line 2215, in make_metavar
        metavar = self.type.get_metavar(param=self, ctx=ctx)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    TypeError: LogLevel.get_metavar() got an unexpected keyword argument 'ctx'
@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged labels Oct 13, 2025
@codecov
Copy link

codecov bot commented Oct 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.82%. Comparing base (28d954c) to head (38a79f7).
⚠️ Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
dandi/cli/base.py 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1723      +/-   ##
==========================================
- Coverage   74.83%   74.82%   -0.01%     
==========================================
  Files          84       84              
  Lines       11701    11701              
==========================================
- Hits         8756     8755       -1     
- Misses       2945     2946       +1
Flag Coverage Δ
unittests 74.82% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic yarikoptic removed the release Create a release when this pr is merged label Oct 13, 2025
@yarikoptic
Copy link
Member Author

yarikoptic commented Oct 13, 2025

macs starting with 3.10 (3.9 is ok) freakout

      running build_ext
      Loading library to get build settings and version: libhdf5.dylib
      error: Unable to load dependency HDF5, make sure HDF5 is installed properly
      on sys.platform='darwin' with platform.machine()='x86_64'
      Library dirs checked: []
      error: dlopen(libhdf5.dylib, 0x0006): tried: 'libhdf5.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OSlibhdf5.dylib' (no such file), '/usr/lib/libhdf5.dylib' (no such file, not in dyld cache), 'libhdf5.dylib' (no such file)
      [end of output]

which is unrelated etc. so proceeding

@yarikoptic yarikoptic merged commit 50491d5 into master Oct 13, 2025
39 of 45 checks passed
@yarikoptic yarikoptic deleted the bf-click branch October 13, 2025 17:21
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

🚀 PR was released in 0.73.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yarikoptic-gitmate yarikoptic-gitmate yarikoptic-gitmate approved these changes

@candleindark candleindark Awaiting requested review from candleindark

@CodyCBakerPhD CodyCBakerPhD Awaiting requested review from CodyCBakerPhD

Assignees

No one assigned

Labels

patch Increment the patch version when merged released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yarikoptic @yarikoptic-gitmate