[pull] master from killbill:master#31
Merged
pull[bot] merged 1 commit intodandycheung:masterfrom Jun 27, 2025
Merged
Conversation
…2133. (#2136) * Test for subscription creation on last day of the month * Experiment... * Experiment... * invoice: Fix wrongly aligned date for cases of end-of-month BCD. See #2133. The method InvoiceDateUtils#advanceByNPeriods simply adds a number of fixed 'periods' but does not try to align with a possible end-of-month BCD. In most cases, BillingIntervalDetail already follows the use of this method with `BillCycleDayCalculator#alignProposedBillCycleDate` but not always, and this is the cause of the issue we are seeing in #2133. Also note, there is already a method `BillCycleDayCalculator#getFutureBillingDateFor` that calls bnopth methods. So the fix is to always call this method. * invoice: Modify unit test to match correct computation of next billing date. See #2133 * invoice: Minor fix to avoid unnecessary iteration * beatrix: Remove unnecessary imports and catalogs --------- Co-authored-by: reshmabidikar <reshmabidikar@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.2)
Can you help keep this open source service alive? 💖 Please sponsor : )