Collapse single word separators at source wrap boundaries - #30
Conversation
|
Round 1 reviewed production commit These are six subagent engineering perspectives, not reviews by the named people. Each reviewer wrote and ran new code. No actionable finding required a production correction in this round.
The evidence runs on macOS 26.5.2 with Xcode 26.6. Intel code ran through Rosetta. It does not establish macOS 13.7.8 behavior, physical IME input, or compositor caret pixels. Reports, probe code, results, and further limits: Round 1 evidence. |
|
Round 2 reviewed P3 performance finding: Separators with strictly printable ASCII neighbors need not query their composed-character range. A 256K-paragraph start-edit pair took 113.411 ms in the base and 131.697 ms in the candidate. Both generated the same glyphs. A separate instrumented experiment saved 9.432 ms with an ASCII shortcut and passed 14 mixed/composed controls. This is layout evidence, not full-app typing latency. The correction will retain the complete composed-character check for every non-ASCII neighbor and will be validated before round three.
No other actionable findings arose. The named lenses are subagent engineering perspectives, not reviews by those people. Runtime coverage remains macOS 26.5.2; older macOS, physical input methods, and final compositor pixels remain outside these probes. |
|
Addressed the round-two P3 finding in e022109. The callback reads both neighbors once and skips the composed-character query only for U+0021–U+007E on both sides. Unicode neighbors retain the full guard. The implementation was delegated to a subagent and then inspected. The corrected Development build passed. Focused checks passed 10,316 assertions per architecture; both negative controls rejected the old behavior. The actual-app separator suite passed 32 checks. Existing wrapping checks passed 74,736 assertions per architecture and 1,305 actual-app checks. Both required desktop suites ran again: multiwindow reproduced its documented library-replacement failure (exit 245), and the aggregate stopped at the recorded Fuzzy UI activation failure. Later entries did not run. Corrected app SHA-256: Round three will review this corrected production commit with new code and evidence. |
|
Round 3 reviewed corrected production commit
This completes all 18 reviews. The named lenses are engineering perspectives, not reviews by those people. Round 3 reports, probes, results, and limits. The corrected Development build and focused checks passed. CI passed for the corrected production commit. Both required desktop suites reproduced their documented failures: library replacement in the multiwindow runner and Fuzzy UI activation in the aggregate runner. Later aggregate entries did not run. macOS 13.7.8 and physical input/compositor behavior remain manual validation limits. |
Single spaces between words no longer add a leading gap when source text wraps. An isolated ordinary space keeps native elasticity, so it can collapse at the previous line’s edge when there is insufficient room. The stored source remains unchanged.
Repeated spaces, trailing spaces, paragraph indentation, tabs, nonbreaking spaces, and spaces with attached combining characters retain their existing behavior. Native text-storage processing owns glyph invalidation; this adds no editing or caret-drawing override. Printable ASCII neighbors use a measured fast path; all other eligible separators retain the full composed-character check. This refines #28.
Validation on macOS 26.5.2 (25F84), Xcode 26.6 (17F113):
All three rounds of six code-writing reviews are complete. The round-two P3 performance finding was corrected before round three. The actual correction reduced a 256K-paragraph start-edit pair from 132.004 to 118.855 ms in the review benchmark, with matching source, glyph properties, and geometry. This measures layout, not full-app typing latency. No actionable review finding remains unaddressed.
Review comments: round one, round two, correction, and round three. The named lenses are engineering perspectives, not reviews by those people.
See the validation record and review index for reproducible evidence and tested app hashes. The screenshot uses native bitmap drawing and omits window-server composition and shadow. macOS 13.7.8, physical input methods, and compositor caret pixels remain manual validation limits.