Replies: 1 comment
|
I agree. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
We see a lot of
[error][ERROR] 2FA token not providedin our logs without being able to map this to a specific user.My suggestion is to improve logging in
src/api/idenitity.rsvaultwarden/src/api/identity.rs
Line 505 in f05398a
by appending the same output as password login failed, e.g.
format!("IP: {}. Username: {}.", ip.ip, username)(Copied fromvaultwarden/src/api/identity.rs
Line 158 in f05398a
So that line could become something like this:
None => err_json!(_json_err_twofactor(&twofactor_ids, &user.uuid, conn).await?, "2FA token not provided ", format!("IP: {}. Username: {}.", ip.ip, user.username)),(Not sure what properties inuserexists)All reactions