test(integration): add GroupBy + Count composition test over search filter - #98
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 99.56% 99.56%
=======================================
Files 25 25
Lines 1157 1157
Branches 128 128
=======================================
Hits 1152 1152
Misses 1 1
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
daniel3303
force-pushed
the
test/add-search-groupby-count-tests
branch
from
May 14, 2026 15:11
87bcd1c to
c76ad1b
Compare
daniel3303
added a commit
that referenced
this pull request
May 14, 2026
…ilter (#98) ## Summary - Adds the first integration test that runs `GroupBy(...).Select(g => new { g.Key, Count = g.Count() })` over a `EF.Functions.Matches` filter. The SQL shape (search predicate in WHERE + GROUP BY + aggregate) is the one behind any "hits per facet" UI. - A regression in `ParadeDbQuerySqlGenerator` that mishandles aggregate composition (e.g., search predicate pushed past the GROUP BY, or score function leaking into the aggregate scope) would slip past the existing single-row `Where`/`Select` tests. ## Code changes - `Equibles.ParadeDB.EntityFrameworkCore.IntegrationTests/SearchWithGroupByCountTests.cs` — new `[Fact]` filtering articles by `Matches(content, "models OR pasta")`, grouping by `Category`, projecting `(Category, Count())`, and asserting `machine-learning=2`, `cooking=1`, and `physics` absent. ## Test plan - [x] `dotnet test --filter "FullyQualifiedName~SearchWithGroupByCountTests" --framework net10.0` passes locally against a `paradedb/paradedb:latest` Testcontainer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GroupBy(...).Select(g => new { g.Key, Count = g.Count() })over aEF.Functions.Matchesfilter. The SQL shape (search predicate in WHERE + GROUP BY + aggregate) is the one behind any "hits per facet" UI.ParadeDbQuerySqlGeneratorthat mishandles aggregate composition (e.g., search predicate pushed past the GROUP BY, or score function leaking into the aggregate scope) would slip past the existing single-rowWhere/Selecttests.Code changes
Equibles.ParadeDB.EntityFrameworkCore.IntegrationTests/SearchWithGroupByCountTests.cs— new[Fact]filtering articles byMatches(content, "models OR pasta"), grouping byCategory, projecting(Category, Count()), and assertingmachine-learning=2,cooking=1, andphysicsabsent.Test plan
dotnet test --filter "FullyQualifiedName~SearchWithGroupByCountTests" --framework net10.0passes locally against aparadedb/paradedb:latestTestcontainer.