Add ISO week number tokens to the clock format#143
Merged
Conversation
Signed-off-by: Daniel Chalmers <daniel.chalmers@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
{week}(ISO 8601 week number) and{weekYear}(ISO week-numbering year) as custom clock format tokens, so formats likeWeek {week}or{weekYear}-W{week}work in the clock display.Supersedes #130 (thanks @spacevortex2435 for the groundwork! token names and several test cases carry over):
DateTimeUtilas documented extension methods instead of private helpers inside the tokenizer (ISOWeekisn't available on .NET Framework, so it's hand-rolled with the same semantics).{week}shows the standard "Bad format" error instead of throwing, with a test covering it.Details
{weekYear}differs from{yyyy}per ISO 8601 — e.g. Dec 30, 2024 is2025-W1.Closes #130
Closes #107
Closes #78