Rename the Shell action type to Open - #67
Merged
Merged
Conversation
The action that launches apps, files, folders, and URLs was surfaced to users as 'Shell', which is developer jargon. Rename the user-facing label and all internal identifiers to 'Open', matching the editor's own description and standard Windows vocabulary. Settings persist Type as an integer (Open is still 2), so existing configurations load unchanged. No behavior change; UseShellExecute launching is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the user-facing action type Shell → Open across the UI and the code, with no behavior change.
Why
"Shell" is developer jargon. What the action actually does is open something: an app, file, folder, or URL. The editor's own hint text already describes it that way ("Choose the app, file, folder, URL, or command to open"), and "Open" matches standard Windows vocabulary. This is a naming-clarity change only.
We deliberately did not add a toggle for
UseShellExecute. That is aProcessStartInfoimplementation detail, not a user-meaningful choice — turning it off would break URLs, folders, and file-association launches while exposing nothing users need. If a "run a raw command line" scenario ever comes up, it belongs as its own distinct action type, not a boolean named after a .NET property.What changed
ActionType.Shell→ActionType.Open(enum member).CreateShellAction→CreateOpenAction,ShellActionDefaults→OpenActionDefaults(file renamed),ApplyShellDefaults/GetShellDefaults/_autoShellDefaults→Open*,ExecuteShell→ExecuteOpen,BrowseShellTarget→BrowseOpenTarget.AGENTS.mdupdated to match.UseShellExecute = truein the launch code is unchanged — that is the .NET API, not the feature name.Compatibility
Settings serialize
Typeas an integer (Openis still2), so existing saved configurations load unchanged. No migration needed.Testing
dotnet build RadialActions.slndotnet test RadialActions.sln