test: cover agent stdout noise, the delete chain, and last coverage tails - #3
Merged
Conversation
…tic tails - process: non-JSON agent output (OSC banners, multibyte lines) surfaces as protocol_line noise and malformed rpc_chunk metadata as protocol_error — the bridge stays alive either way - delete chain end-to-end over HTTP with mockMode off: DELETE /api/sessions/:id removes the underlying omp session file + artifacts, while a session opened from history keeps its pre-existing file - static: missing dist directory serves the build-me placeholder page - config: group/world-readable and corrupt config.json warn without crashing Server suite: 84 → 91 tests; line coverage 96.0% → 96.9%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final layer of the coverage work from #2 — everything else was already at or above target.
New tests (server 84 → 91; line coverage 96.0% → 96.9%)
process): OSC escape banners and multibyte non-JSON lines surface asprotocol_lineframes with control characters intact, malformedrpc_chunkmetadata surfaces asprotocol_error— and in both cases the bridge stays alive and the eventualreadyframe still arrives. Untrusted agent output cannot take the bridge down.hardening,mockMode: falseso filesystem deletion is real):DELETE /api/sessions/:id→ the underlying omp session file and its artifacts directory are removed over HTTP; a session opened from the history browser (resumedFromHistory) keeps its pre-existing file while only the registry entry disappears.loadConfigwarns (never crashes) on a group/world-readable or corruptconfig.json.Verification:
bun run checkgreen · 91 server + 57 web tests pass · coverage thresholds (server ≥93%, web ≥90%) pass locally and gate CI.