fix: content type validation should be case insensitive - #1052
Merged
wolveix merged 1 commit intoJun 29, 2026
Merged
Conversation
Collaborator
|
Awesome find and fix, thanks @hlavacekvit! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1052 +/- ##
=======================================
Coverage 93.16% 93.16%
=======================================
Files 23 23
Lines 4918 4919 +1
=======================================
+ Hits 4582 4583 +1
Misses 272 272
Partials 64 64 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this in production: an old .NET app couldn't call our Huma-based service because it sends Content-Type: Application/Json (capitalized), and Huma responded with 415 Unsupported Media Type.
Media types are case-insensitive per RFC 9110 §8.3.1, but the format lookup (a.formats[ct]) is a case-sensitive map access, so Application/Json doesn't match the registered application/json.
Fixed by lowercasing the media-type token. Added a test as well